You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jan-Pascal (JIRA)" <ji...@apache.org> on 2009/08/20 23:19:14 UTC
[jira] Created: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
'ant javacc' in root project should also properly create contrib/queryparser Java files
---------------------------------------------------------------------------------------
Key: LUCENE-1829
URL: https://issues.apache.org/jira/browse/LUCENE-1829
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/*
Affects Versions: 2.9
Reporter: Jan-Pascal
Priority: Minor
'ant javacc' in the project root doesn't run javacc in contrib/queryparser
'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1829) 'ant javacc' in root
project should also properly create contrib/queryparser Java files
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745849#action_12745849 ]
Luis Alves edited comment on LUCENE-1829 at 8/21/09 1:07 AM:
-------------------------------------------------------------
I found some free time, and fixed the patch.
It should apply fine against the trunk now.
Jan can you test it.
was (Author: lafa):
I found dome free time, and fixed the patch, should work fine against the trunk now.
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Priority: Minor
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745846#action_12745846 ]
Luis Alves commented on LUCENE-1829:
------------------------------------
Hi Jan,
Your patch does not apply clean against the trunk.
I think the file names include part of your path.
Please check and resubmit, I'll try again :)
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Priority: Minor
> Attachments: contrib-queryparser-javacc.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch updated LUCENE-1829:
----------------------------------
Fix Version/s: 2.9
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luis Alves updated LUCENE-1829:
-------------------------------
Attachment: LUCENE-1829.patch
I found dome free time, and fixed the patch, should work fine against the trunk now.
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Priority: Minor
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747018#action_12747018 ]
Luis Alves commented on LUCENE-1829:
------------------------------------
{quote}
Would it still be possible to also treat the javacc ant goal of the surround parser in the same way?
{quote}
Can you please, create another JIRA for the surround parser.
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Jan-Pascal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan-Pascal updated LUCENE-1829:
-------------------------------
Attachment: contrib-queryparser-javacc.patch
This patch caused 'ant javacc' to also run in contrib/queryparser, and automates the steps in README.javacc in the ant script.
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Priority: Minor
> Attachments: contrib-queryparser-javacc.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Jan-Pascal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745876#action_12745876 ]
Jan-Pascal commented on LUCENE-1829:
------------------------------------
Luis, works fine for me.
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746005#action_12746005 ]
Luis Alves commented on LUCENE-1829:
------------------------------------
Hi Michael,
This is an update to the build files, to allow javacc to be rebuild StandardSyntaxQueryparser
from the .jj files without manually having to change ParseException.java.
The patch looks good, I tested Jan-Pascal patch on my system
and Jan-Pascal also confirm that it works with the minor changes I made.
Can you please commit it, it would be great to have on 2.9.
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Busch reassigned LUCENE-1829:
-------------------------------------
Assignee: Michael Busch
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747033#action_12747033 ]
Paul Elschot commented on LUCENE-1829:
--------------------------------------
Ok, see LUCENE-1851
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Issue Comment Edited: (LUCENE-1829) 'ant javacc' in root
project should also properly create contrib/queryparser Java files
Posted by "Luis Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746005#action_12746005 ]
Luis Alves edited comment on LUCENE-1829 at 8/21/09 8:04 AM:
-------------------------------------------------------------
Hi Michael,
This is an update to the build files, to allow javacc to be rebuild StandardSyntaxQueryparser
from the .jj files without manually having to change ParseException.java.
The patch looks good.
I tested Jan-Pascal patch on my system
and Jan-Pascal also confirms that it works
with the small changes I made.
Can you please commit it, it would be great to have it on 2.9.
was (Author: lafa):
Hi Michael,
This is an update to the build files, to allow javacc to be rebuild StandardSyntaxQueryparser
from the .jj files without manually having to change ParseException.java.
The patch looks good, I tested Jan-Pascal patch on my system
and Jan-Pascal also confirm that it works with the minor changes I made.
Can you please commit it, it would be great to have on 2.9.
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Paul Elschot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746449#action_12746449 ]
Paul Elschot commented on LUCENE-1829:
--------------------------------------
Would it still be possible to also treat the javacc ant goal of the surround parser in the same way?
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1829) 'ant javacc' in root project should
also properly create contrib/queryparser Java files
Posted by "Michael Busch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746016#action_12746016 ]
Michael Busch commented on LUCENE-1829:
---------------------------------------
I deleted my contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java.
When I run now ant javacc after applying this patch I'm getting:
{noformat}
javacc:
[replaceregexp] The following file is missing: '/Users/buschmi/work/svn/lucene/trunk/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java'
[replaceregexp] The following file is missing: '/Users/buschmi/work/svn/lucene/trunk/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java'
[replaceregexp] The following file is missing: '/Users/buschmi/work/svn/lucene/trunk/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java'
[replaceregexp] The following file is missing: '/Users/buschmi/work/svn/lucene/trunk/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java'
[replaceregexp] The following file is missing: '/Users/buschmi/work/svn/lucene/trunk/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java'
[replaceregexp] The following file is missing: '/Users/buschmi/work/svn/lucene/trunk/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java'
[replaceregexp] The following file is missing: '/Users/buschmi/work/svn/lucene/trunk/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java'
{noformat}
At the end the ParseException.java is still missing, so it wasn't regenerated. Shouldn't this work now?
> 'ant javacc' in root project should also properly create contrib/queryparser Java files
> ---------------------------------------------------------------------------------------
>
> Key: LUCENE-1829
> URL: https://issues.apache.org/jira/browse/LUCENE-1829
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Jan-Pascal
> Assignee: Michael Busch
> Priority: Minor
> Fix For: 2.9
>
> Attachments: contrib-queryparser-javacc.patch, LUCENE-1829.patch
>
>
> 'ant javacc' in the project root doesn't run javacc in contrib/queryparser
> 'ant javacc' in contrib/queryparser does not properly create the Java files. What still needs to be done by hand is (partly!) described in contrib/queryparser/README.javacc. I think this process should be automated. Patch provided.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org