You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Kyrremann (via GitHub)" <gi...@apache.org> on 2023/10/02 11:50:12 UTC
[PR] feat: enable HTTPRoute for Gateway API [airflow]
Kyrremann opened a new pull request, #34716:
URL: https://github.com/apache/airflow/pull/34716
We are moving to Gateway API with HTTPRoute instead of using regular Ingress resources. It would be nice if this chart would allow us to make the two resources needed so we don't have to make them manually before installing the chart.
From https://gateway-api.sigs.k8s.io/
When using the Gateway API to manage ingress traffic, the Gateway resource defines a point of access at which traffic can be routed across multiple contexts -- for example, from outside the cluster to inside the cluster (north/south traffic).
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1342914940
##########
chart/templates/webserver/webserver-httproute.yaml:
##########
@@ -0,0 +1,82 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/}}
+
+################################
+## Airflow Webserver HTTPRoute
+#################################
+{{- if .Values.httpRoute.web.enabled }}
+{{- $fullname := (include "airflow.fullname" .) }}
+kind: HTTPRoute
+apiVersion: gateway.networking.k8s.io/v1beta1
+metadata:
+ name: {{ $fullname }}-httproute
+ labels:
+ tier: airflow
+ component: airflow-httproute
+ release: {{ .Release.Name }}
+ chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+ heritage: {{ .Release.Service }}
+ {{- if or (.Values.labels) (.Values.webserver.labels) }}
+ {{- mustMerge .Values.webserver.labels .Values.labels | toYaml | nindent 4 }}
+ {{- end }}
+ {{- with .Values.httpRoute.web.annotations }}
+ annotations: {{- toYaml . | nindent 4 }}
+ {{- end }}
+spec:
+ parentRefs:
+ - kind: Gateway
+ name: {{ .Values.httpRoute.web.gateway.name }}
+ namespace: {{ .Values.httpRoute.web.gateway.namespace }}
+ {{- with .Values.httpRoute.web.hostnames }}
+ hostnames:
+ {{- . | toYaml | nindent 4 }}
+ {{- end }}
+ rules:
+ - backendRefs:
+ - name: {{ $fullname }}-webserver
+ port: 8080
Review Comment:
Can this use a named port (`airflow-ui`) instead? If not, it needs to use `.Values.ports.airflowUI` instead.
##########
chart/values.yaml:
##########
@@ -220,6 +220,31 @@ ingress:
# the name of a pre-created Secret containing a TLS private key and certificate
secretName: ""
+# Enable the creation of a Kubernetes HTTPRoute and HealthCheckPolicy
+httpRoute:
+ web:
+ # Enable web ingress resource
Review Comment:
```suggestion
# Enable web HTTPRoute resource
```
nit
##########
chart/templates/flower/flower-httproute.yaml:
##########
@@ -0,0 +1,82 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/}}
+
+################################
+## Airflow Flower HTTPRoute
+#################################
+{{- if .Values.httpRoute.flower.enabled }}
+{{- $fullname := (include "airflow.fullname" .) }}
+kind: HTTPRoute
+apiVersion: gateway.networking.k8s.io/v1beta1
+metadata:
+ name: {{ $fullname }}-httproute
+ labels:
+ tier: airflow
+ component: airflow-httproute
+ release: {{ .Release.Name }}
+ chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+ heritage: {{ .Release.Service }}
+ {{- if or (.Values.labels) (.Values.flower.labels) }}
+ {{- mustMerge .Values.flower.labels .Values.labels | toYaml | nindent 4 }}
+ {{- end }}
+ {{- with .Values.httpRoute.flower.annotations }}
+ annotations: {{- toYaml . | nindent 4 }}
+ {{- end }}
+spec:
+ parentRefs:
+ - kind: Gateway
+ name: {{ .Values.httpRoute.flower.gateway.name }}
+ namespace: {{ .Values.httpRoute.flower.gateway.namespace }}
+ {{- with .Values.httpRoute.flower.hostnames }}
+ hostnames:
+ {{- . | toYaml | nindent 4 }}
+ {{- end }}
+ rules:
+ - backendRefs:
+ - name: {{ $fullname }}-flower
+ port: 8080
Review Comment:
Same here, plus flower uses 5555 by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1355248925
##########
helm_tests/webserver/test_httproute_flower.py:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+import pytest
+
+from tests.charts.helm_template_generator import render_chart
+
+
+class TestHttpRouteFlower:
+ """Tests httpRoute flower."""
+
+ def test_should_pass_validation_with_httproute_enabled_and_gateway_set(self):
+ render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ ) # checks that no validation exception is raised
+
Review Comment:
```suggestion
```
I'm not sure we need this test when we have the next one. Each test isn't that big, but in total they add up.
##########
helm_tests/webserver/test_httproute_flower.py:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+import pytest
+
+from tests.charts.helm_template_generator import render_chart
+
+
+class TestHttpRouteFlower:
+ """Tests httpRoute flower."""
+
+ def test_should_pass_validation_with_httproute_enabled_and_gateway_set(self):
+ render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ ) # checks that no validation exception is raised
+
+ def test_should_check_that_both_httproute_and_healthcheckpolicy_are_created(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert 2 == len(docs)
+ assert "HTTPRoute" == jmespath.search("kind", docs[0])
+ assert "HealthCheckPolicy" == jmespath.search("kind", docs[1])
+
+ def test_should_allow_more_than_one_annotation(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "annotations": {"aa": "bb", "cc": "dd"},
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert {"aa": "bb", "cc": "dd"} == jmespath.search("metadata.annotations", docs[0])
+
+ def test_should_set_httproute_gateway_name(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "foo", "namespace": "bar"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert "foo" == jmespath.search("spec.parentRefs[0].name", docs[0])
+
+ def test_should_httproute_hostnames_entry_not_exist(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert not jmespath.search("spec.hostnames", docs[0])
Review Comment:
Should we have a test that hostnames do get added as well?
##########
helm_tests/webserver/test_httproute_flower.py:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+import pytest
+
+from tests.charts.helm_template_generator import render_chart
+
+
+class TestHttpRouteFlower:
+ """Tests httpRoute flower."""
+
+ def test_should_pass_validation_with_httproute_enabled_and_gateway_set(self):
+ render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ ) # checks that no validation exception is raised
+
+ def test_should_check_that_both_httproute_and_healthcheckpolicy_are_created(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert 2 == len(docs)
+ assert "HTTPRoute" == jmespath.search("kind", docs[0])
+ assert "HealthCheckPolicy" == jmespath.search("kind", docs[1])
+
+ def test_should_allow_more_than_one_annotation(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "annotations": {"aa": "bb", "cc": "dd"},
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert {"aa": "bb", "cc": "dd"} == jmespath.search("metadata.annotations", docs[0])
+
+ def test_should_set_httproute_gateway_name(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "foo", "namespace": "bar"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert "foo" == jmespath.search("spec.parentRefs[0].name", docs[0])
+
+ def test_should_httproute_hostnames_entry_not_exist(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert not jmespath.search("spec.hostnames", docs[0])
+
+ @pytest.mark.parametrize(
+ "value, expected",
+ [
+ (None, False),
+ (False, False),
+ (True, True),
+ ],
+ )
+ def test_httproute_created(self, value, expected):
+ values={"httpRoute": {"flower": {"gateway": {"name": "test-gateway", "namespace": "test"}}}}
+ if value is not None:
+ values["httpRoute"]["flower"]["enabled"] = value
+ docs = render_chart(values=values, show_only=["templates/flower/flower-httproute.yaml"])
+ assert expected == (2 == len(docs))
+
+ def test_should_add_component_specific_labels(self):
+ docs = render_chart(
+ values={
+ "httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}},
+ "flower": {
+ "labels": {"test_label": "test_label_value"},
+ },
+ },
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert "test_label" in jmespath.search("metadata.labels", docs[0])
+ assert jmespath.search("metadata.labels", docs[0])["test_label"] == "test_label_value"
Review Comment:
Shouldn't we check the HealthCheckPolicy also?
##########
chart/templates/flower/flower-httproute.yaml:
##########
@@ -0,0 +1,82 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/}}
+
+################################
+## Airflow Flower HTTPRoute
+#################################
+{{- if .Values.httpRoute.flower.enabled }}
+{{- $fullname := (include "airflow.fullname" .) }}
+kind: HTTPRoute
+apiVersion: gateway.networking.k8s.io/v1beta1
+metadata:
+ name: {{ $fullname }}-httproute
Review Comment:
Shouldn't this name be specific to flower? What if someone wanted to enable both?
##########
helm_tests/webserver/test_httproute_flower.py:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+import pytest
+
+from tests.charts.helm_template_generator import render_chart
+
+
+class TestHttpRouteFlower:
+ """Tests httpRoute flower."""
+
+ def test_should_pass_validation_with_httproute_enabled_and_gateway_set(self):
+ render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ ) # checks that no validation exception is raised
+
+ def test_should_check_that_both_httproute_and_healthcheckpolicy_are_created(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert 2 == len(docs)
+ assert "HTTPRoute" == jmespath.search("kind", docs[0])
+ assert "HealthCheckPolicy" == jmespath.search("kind", docs[1])
+
+ def test_should_allow_more_than_one_annotation(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "annotations": {"aa": "bb", "cc": "dd"},
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert {"aa": "bb", "cc": "dd"} == jmespath.search("metadata.annotations", docs[0])
+
+ def test_should_set_httproute_gateway_name(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "foo", "namespace": "bar"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert "foo" == jmespath.search("spec.parentRefs[0].name", docs[0])
+
+ def test_should_httproute_hostnames_entry_not_exist(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert not jmespath.search("spec.hostnames", docs[0])
+
+ @pytest.mark.parametrize(
+ "value, expected",
+ [
+ (None, False),
+ (False, False),
+ (True, True),
+ ],
+ )
+ def test_httproute_created(self, value, expected):
+ values={"httpRoute": {"flower": {"gateway": {"name": "test-gateway", "namespace": "test"}}}}
+ if value is not None:
+ values["httpRoute"]["flower"]["enabled"] = value
+ docs = render_chart(values=values, show_only=["templates/flower/flower-httproute.yaml"])
+ assert expected == (2 == len(docs))
Review Comment:
It might be better to actually assert the count directly. If you got 1 doc and checked "false" it'd still match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1356119603
##########
chart/templates/flower/flower-httproute.yaml:
##########
@@ -0,0 +1,82 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/}}
+
+################################
+## Airflow Flower HTTPRoute
+#################################
+{{- if .Values.httpRoute.flower.enabled }}
+{{- $fullname := (include "airflow.fullname" .) }}
+kind: HTTPRoute
+apiVersion: gateway.networking.k8s.io/v1beta1
+metadata:
+ name: {{ $fullname }}-httproute
Review Comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1356131694
##########
helm_tests/webserver/test_httproute_flower.py:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+import pytest
+
+from tests.charts.helm_template_generator import render_chart
+
+
+class TestHttpRouteFlower:
+ """Tests httpRoute flower."""
+
+ def test_should_pass_validation_with_httproute_enabled_and_gateway_set(self):
+ render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ ) # checks that no validation exception is raised
+
+ def test_should_check_that_both_httproute_and_healthcheckpolicy_are_created(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert 2 == len(docs)
+ assert "HTTPRoute" == jmespath.search("kind", docs[0])
+ assert "HealthCheckPolicy" == jmespath.search("kind", docs[1])
+
+ def test_should_allow_more_than_one_annotation(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "annotations": {"aa": "bb", "cc": "dd"},
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert {"aa": "bb", "cc": "dd"} == jmespath.search("metadata.annotations", docs[0])
+
+ def test_should_set_httproute_gateway_name(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "foo", "namespace": "bar"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert "foo" == jmespath.search("spec.parentRefs[0].name", docs[0])
+
+ def test_should_httproute_hostnames_entry_not_exist(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert not jmespath.search("spec.hostnames", docs[0])
Review Comment:
Yeah, let's just rewrite this test to cover them being added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1820858170
What else needs to be done, as this branch is just getting more and more outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1805264433
Is it possible to get some traction here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1825521152
No worries, I can try to keep this PR up to date.
One thing that I haven't thought about is that `HealthCheckPolicy` is GKE specific, so we may not want merge this in :/ Not sure how to fix this issue, as I need both resources to run it on GKE.
We may just close this PR. If I need to create one resource outside the chart, creating another one is not that much hassle. I've already solved the problem on my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #34716: feat: enable HTTPRoute for Gateway API
URL: https://github.com/apache/airflow/pull/34716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1747477431
> Are we manually adding values to `values.schema.json`? I've only worked with a `schema.yaml` that then generated the `json`.
Yeah, done manually. Should be pretty easy to sort out (lots of examples in there haha), but if you get stuck just reach out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1759136722
Had some extra commas in the values schema that is now fixed, pluss added a new test for healthCheckPolicy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1746329260
Got `pytest` to work (skipped virtual env), and tests now work at least on my machine! Had to add two CRDs to the test framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1342902526
##########
chart/values.yaml:
##########
@@ -220,6 +220,31 @@ ingress:
# the name of a pre-created Secret containing a TLS private key and certificate
secretName: ""
+# Enable the creation of a Kubernetes HTTPRoute and HealthCheckPolicy
+httpRoute:
+ web:
+ # Enable web ingress resource
+ enabled: false
+ # Annotations for the web HTTPRoute
+ annotations: {}
+ # The hostnames or hosts configuration for the web HTTPRoute
+ hostnames: []
+ # The Gateway API configuration
+ gateway:
+ name: your-gateway
+ namespace: namespace-for-your-gateway
Review Comment:
You can keep them empty, and check in the template if they are provided, and fail if they are not (at least name, and maybe use chart namespace as namespace for gateway). Otherwise, users will try to use it with default values, and it will fail.
##########
chart/values.yaml:
##########
@@ -220,6 +220,31 @@ ingress:
# the name of a pre-created Secret containing a TLS private key and certificate
secretName: ""
+# Enable the creation of a Kubernetes HTTPRoute and HealthCheckPolicy
+httpRoute:
+ web:
+ # Enable web ingress resource
+ enabled: false
+ # Annotations for the web HTTPRoute
+ annotations: {}
+ # The hostnames or hosts configuration for the web HTTPRoute
+ hostnames: []
+ # The Gateway API configuration
+ gateway:
+ name: your-gateway
+ namespace: namespace-for-your-gateway
+ flower:
+ # Enable flower HTTPRoute resource
+ enabled: false
+ # Annotations for the flower HTTPRoute
+ annotations: {}
+ # The hostnames or hosts configuration for the flower HTTPRoute
+ hostnames: []
+ # The Gateway API configuration
+ gateway:
+ name: your-gateway
+ namespace: namespace-for-your-gateway
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1821829410
> What else needs to be done, as this branch is just getting more and more outdated.
People who review it must find their free time (usually during their weekends and evenings) to finally review it and approve. All the contributors and maintainers here are generally not paid for merging those kind of PRs and do what they can to spend some of their time to review things - but sometimes their work, families and generally life intervenes.
What you can do to do now is:
* rebase your PR periodically, to make sure the CI passes with latest version and is generally a "recent" build
* keep on reminding like you already do - gently and not too often, simply be persistent but considerate to other people
Take into account we have 100s of PRs and helm chart is generally released on different schedule than airflow on providers, so it might be less of a priority to merge outstanding PRs for Helm chart when we have (just about to) wave of providers and big Airflow 2.8.0 (in the coming weeks) release coming.
You have exactly one PR to care about, maintainers who can review them take responsibility for often loooking at and reviewing several 10s of them, so if you exercise a bit of empathy, I hope it's easier to understand that it's you who should make a bit deliberate, persistent, but gentle effort and show a bit of patience in this relation. Which I heartily encourage - it pays of regardless, and I also invite to open a few PRs - especially smaller (see below) for other things in parallel, this might also make the back-forth communication more frequent, and you might use that to drag attention to this PR. That makes the relation a bit more balanced and gives you something else to do while you are waiting for the review.
Your PR is also on the "bigger" side with 500 lines of code and 7 files. What helps in many cases if you split your PRs into smaller ones - then they are usually reviewed and merged very fast. With bigger PRs it takes a lot of mental power and time from reviewer to focus and review the whole of it - and it usually quite disproportionate to the size (I tend to think it's more like quadratic growth with the number of lines). Not sure if you can do it in this case, but splitting one PR into sequence of more isolated and standalone PRs helps a lot with speeding up the review process.
I hope I answered your questions. Generally patience, consideration, empathy and being persistent is all that it needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1754558718
Anyone have time to take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1744478997
@hussein-awala just to be sure, the helm tests are written in Python? So I'm guessing I can use `helm_tests/webserver/test_ingress_flower.py` as inspiration.
Are we manually adding values to `values.schema.json`? I've only worked with a `schema.yaml` that then generated the `json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1745128719
Added one test for now, making another tomorrow. Couldn't manage to run the test locally (neither through Breeze or virtualenv pytest). Hopefully they will be run automatically with a push to the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1356126098
##########
helm_tests/webserver/test_httproute_flower.py:
##########
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import jmespath
+import pytest
+
+from tests.charts.helm_template_generator import render_chart
+
+
+class TestHttpRouteFlower:
+ """Tests httpRoute flower."""
+
+ def test_should_pass_validation_with_httproute_enabled_and_gateway_set(self):
+ render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ ) # checks that no validation exception is raised
+
+ def test_should_check_that_both_httproute_and_healthcheckpolicy_are_created(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert 2 == len(docs)
+ assert "HTTPRoute" == jmespath.search("kind", docs[0])
+ assert "HealthCheckPolicy" == jmespath.search("kind", docs[1])
+
+ def test_should_allow_more_than_one_annotation(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "annotations": {"aa": "bb", "cc": "dd"},
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert {"aa": "bb", "cc": "dd"} == jmespath.search("metadata.annotations", docs[0])
+
+ def test_should_set_httproute_gateway_name(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "foo", "namespace": "bar"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert "foo" == jmespath.search("spec.parentRefs[0].name", docs[0])
+
+ def test_should_httproute_hostnames_entry_not_exist(self):
+ docs = render_chart(
+ values={"httpRoute": {"flower": {"enabled": True,
+ "gateway": {"name": "test-gateway", "namespace": "test"}}}},
+ show_only=["templates/flower/flower-httproute.yaml"],
+ )
+ assert not jmespath.search("spec.hostnames", docs[0])
Review Comment:
It's probably better to only have a test that checks if they are added. Do we really care about them not getting added if not specified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1742873394
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1343624611
##########
chart/values.yaml:
##########
@@ -220,6 +220,31 @@ ingress:
# the name of a pre-created Secret containing a TLS private key and certificate
secretName: ""
+# Enable the creation of a Kubernetes HTTPRoute and HealthCheckPolicy
+httpRoute:
+ web:
+ # Enable web ingress resource
+ enabled: false
+ # Annotations for the web HTTPRoute
+ annotations: {}
+ # The hostnames or hosts configuration for the web HTTPRoute
+ hostnames: []
+ # The Gateway API configuration
+ gateway:
+ name: your-gateway
+ namespace: namespace-for-your-gateway
Review Comment:
I'll leave them both empty. My guess is that k8s admins will not have the gateway running in the same namespace as Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1748279363
Then I think everything should work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "Kyrremann (via GitHub)" <gi...@apache.org>.
Kyrremann commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1343629040
##########
chart/templates/webserver/webserver-httproute.yaml:
##########
@@ -0,0 +1,82 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/}}
+
+################################
+## Airflow Webserver HTTPRoute
+#################################
+{{- if .Values.httpRoute.web.enabled }}
+{{- $fullname := (include "airflow.fullname" .) }}
+kind: HTTPRoute
+apiVersion: gateway.networking.k8s.io/v1beta1
+metadata:
+ name: {{ $fullname }}-httproute
+ labels:
+ tier: airflow
+ component: airflow-httproute
+ release: {{ .Release.Name }}
+ chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+ heritage: {{ .Release.Service }}
+ {{- if or (.Values.labels) (.Values.webserver.labels) }}
+ {{- mustMerge .Values.webserver.labels .Values.labels | toYaml | nindent 4 }}
+ {{- end }}
+ {{- with .Values.httpRoute.web.annotations }}
+ annotations: {{- toYaml . | nindent 4 }}
+ {{- end }}
+spec:
+ parentRefs:
+ - kind: Gateway
+ name: {{ .Values.httpRoute.web.gateway.name }}
+ namespace: {{ .Values.httpRoute.web.gateway.namespace }}
+ {{- with .Values.httpRoute.web.hostnames }}
+ hostnames:
+ {{- . | toYaml | nindent 4 }}
+ {{- end }}
+ rules:
+ - backendRefs:
+ - name: {{ $fullname }}-webserver
+ port: 8080
Review Comment:
As far as I can see from the documentation it needs to be the port number.
https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.PortNumber
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34716:
URL: https://github.com/apache/airflow/pull/34716#issuecomment-1826176241
> No worries, I can try to keep this PR up to date. One thing that I haven't thought about is that `HealthCheckPolicy` is GKE specific, so we may not want merge this in :/ Not sure how to fix this issue, as I need both resources to run it on GKE.
>
> We may just close this PR. If I need to create one resource outside the chart, creating another one is not that much hassle. I've already solved the problem on my side.
OK. closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org