You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/04/04 13:41:00 UTC
[jira] [Work logged] (HIVE-27185) Iceberg: Cache iceberg table while loading for stats
[ https://issues.apache.org/jira/browse/HIVE-27185?focusedWorklogId=854793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854793 ]
ASF GitHub Bot logged work on HIVE-27185:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/23 13:40
Start Date: 04/Apr/23 13:40
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4165:
URL: https://github.com/apache/hive/pull/4165#discussion_r1157274432
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -315,8 +316,9 @@ public boolean canProvideBasicStatistics() {
@Override
public Map<String, String> getBasicStatistics(Partish partish) {
org.apache.hadoop.hive.ql.metadata.Table hmsTable = partish.getTable();
- TableDesc tableDesc = Utilities.getTableDesc(hmsTable);
- Table table = Catalogs.loadTable(conf, tableDesc.getProperties());
+ Table table;
+ // For write queries where rows got modified, don't fetch from cache as values could have changed.
+ table = getTable(hmsTable);
Review Comment:
can we inline the declaration and assignment?
Issue Time Tracking
-------------------
Worklog Id: (was: 854793)
Time Spent: 2h (was: 1h 50m)
> Iceberg: Cache iceberg table while loading for stats
> ----------------------------------------------------
>
> Key: HIVE-27185
> URL: https://issues.apache.org/jira/browse/HIVE-27185
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Presently iceberg for stats loads the iceberg table multiple times for stats via different routes.
> Cache it to avoid reading/loading the iceberg table multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)