You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2026/06/12 07:46:38 UTC
[PR] chore: improve ci workflow, ensure built parser committed, cleanup [cordova-node-xcode]
erisu opened a new pull request, #166:
URL: https://github.com/apache/cordova-node-xcode/pull/166
* Create `npm run build` script
* Logically builds the parser
* Automatically prefixes the built parser with the Apache-2.0 license header
* Update `npm test`
* Include linting before tests
* Add `DEVELOPMENT.md`
* Move build steps from `README.md` to here
* Add more development notes
* Clean up `README.md`
* Remove the license section, as we have a `LICENSE` file and defined in `package.json`
* Refactor the example and add some comments
* Refactor CI workflow
* Fail if changes are detected after running `npm run build`. This implies a difference between the committed and generated parser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: improve ci workflow, ensure built parser committed, cleanup [cordova-node-xcode]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #166:
URL: https://github.com/apache/cordova-node-xcode/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: improve ci workflow, ensure built parser committed, cleanup [cordova-node-xcode]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #166:
URL: https://github.com/apache/cordova-node-xcode/pull/166#issuecomment-4714569277
## [Codecov](https://app.codecov.io/gh/apache/cordova-node-xcode/pull/166?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 97.32%. Comparing base ([`e7df64a`](https://app.codecov.io/gh/apache/cordova-node-xcode/commit/e7df64aed8f998a2dd224683fcdbbf97c7c5e1fd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`44dc528`](https://app.codecov.io/gh/apache/cordova-node-xcode/commit/44dc528468c44984f28c82df26f676bdaba2d617?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
- Coverage 97.32% 97.32% -0.01%
==========================================
Files 51 51
Lines 10903 10902 -1
==========================================
- Hits 10611 10610 -1
Misses 292 292
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cordova-node-xcode/pull/166?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org