[GitHub] [doris] yiguolei commented on a diff in pull request #13993: [fix](schema) Release memory of TabletSchemaPB in RowsetMetaPB

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #13993:
URL: https://github.com/apache/doris/pull/13993#discussion_r1016049125


##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -53,12 +53,14 @@ class RowsetMeta {
     }
 
     virtual bool init_from_pb(const RowsetMetaPB& rowset_meta_pb) {
-        _rowset_meta_pb = rowset_meta_pb;
-        if (_rowset_meta_pb.has_tablet_schema()) {
+        if (rowset_meta_pb.has_tablet_schema()) {
             _schema = TabletSchemaCache::instance()->insert(
-                    _rowset_meta_pb.tablet_schema().SerializeAsString());
-            _rowset_meta_pb.clear_tablet_schema();
+                    rowset_meta_pb.tablet_schema().SerializeAsString());
         }
+        auto& mut_rowset_meta_pb = const_cast<RowsetMetaPB&>(rowset_meta_pb);

Review Comment:
   Add these explaination as comment to code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org