You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/06/13 15:07:35 UTC

[GitHub] [hive] pvary commented on a diff in pull request #3354: HIVE-26307: Avoid FS init in FileIO::newInputFile in vectorized Iceberg reads

pvary commented on code in PR #3354:
URL: https://github.com/apache/hive/pull/3354#discussion_r895836024


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -381,100 +400,67 @@ private CloseableIterable<T> newAvroIterable(
       Avro.ReadBuilder avroReadBuilder = Avro.read(inputFile)
           .project(readSchema)
           .split(task.start(), task.length());
+

Review Comment:
   The first check in `openVectorized` is this:
   ```
         Preconditions.checkArgument(!task.file().format().equals(FileFormat.AVRO),
             "Vectorized execution is not yet supported for Iceberg avro tables. " +
                 "Please turn off vectorization and retry the query.");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org