You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/06/18 10:20:22 UTC
[GitHub] codecov-io commented on issue #3777: Avoid converting ByteString to
bytes in attachment inlining flow
codecov-io commented on issue #3777: Avoid converting ByteString to bytes in attachment inlining flow
URL: https://github.com/apache/incubator-openwhisk/pull/3777#issuecomment-398009157
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=h1) Report
> Merging [#3777](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b99aaa3c8b4e6e7dac167f7b6f9a5e9ed13989d5?src=pr&el=desc) will **increase** coverage by `1.07%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3777 +/- ##
==========================================
+ Coverage 74.05% 75.13% +1.07%
==========================================
Files 132 132
Lines 6186 6145 -41
Branches 392 380 -12
==========================================
+ Hits 4581 4617 +36
+ Misses 1605 1528 -77
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...k/core/database/memory/MemoryAttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUF0dGFjaG1lbnRTdG9yZS5zY2FsYQ==) | `95% <100%> (+0.26%)` | :arrow_up: |
| [.../scala/whisk/core/database/AttachmentSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQXR0YWNobWVudFN1cHBvcnQuc2NhbGE=) | `100% <100%> (ø)` | |
| [...n/scala/whisk/core/database/CouchDbRestStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RTdG9yZS5zY2FsYQ==) | `73.23% <100%> (+2.45%)` | :arrow_up: |
| [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `99.18% <100%> (+2.73%)` | :arrow_up: |
| [...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `84.61% <0%> (-3.85%)` | :arrow_down: |
| [...cala/src/main/scala/whisk/http/ErrorResponse.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvRXJyb3JSZXNwb25zZS5zY2FsYQ==) | `89.77% <0%> (+1.13%)` | :arrow_up: |
| [...ain/scala/whisk/core/entity/ActivationResult.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0FjdGl2YXRpb25SZXN1bHQuc2NhbGE=) | `92.3% <0%> (+1.53%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=footer). Last update [b99aaa3...a461306](https://codecov.io/gh/apache/incubator-openwhisk/pull/3777?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services