You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/23 19:20:54 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #7358: limit tables/views returned if schema is not provided

codecov-io commented on issue #7358: limit tables/views returned if schema is not provided
URL: https://github.com/apache/incubator-superset/pull/7358#issuecomment-485939493
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7358?src=pr&el=h1) Report
   > Merging [#7358](https://codecov.io/gh/apache/incubator-superset/pull/7358?src=pr&el=desc) into [lyftga](https://codecov.io/gh/apache/incubator-superset/commit/5f14b559e214b994a28cca1df33b7e475988b17a?src=pr&el=desc) will **decrease** coverage by `1.06%`.
   > The diff coverage is `8.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7358/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7358?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           lyftga    #7358      +/-   ##
   ==========================================
   - Coverage   65.71%   64.65%   -1.07%     
   ==========================================
     Files         429      426       -3     
     Lines       22521    20909    -1612     
     Branches     2511     2304     -207     
   ==========================================
   - Hits        14800    13518    -1282     
   + Misses       7584     7267     -317     
   + Partials      137      124      -13
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7358?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.03% <0%> (-4.9%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.46% <50%> (-0.11%)` | :arrow_down: |
   | [...set/assets/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `31.53% <0%> (-11.16%)` | :arrow_down: |
   | [...s/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWJzLmpzeA==) | `63.33% <0%> (-8.52%)` | :arrow_down: |
   | [...ts/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZVZpZXdDb250YWluZXIuanN4) | `33.79% <0%> (-6.48%)` | :arrow_down: |
   | [superset/data/country\_map.py](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9jb3VudHJ5X21hcC5weQ==) | `28.12% <0%> (-5.21%)` | :arrow_down: |
   | [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `75.55% <0%> (-4.64%)` | :arrow_down: |
   | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `74.43% <0%> (-4.14%)` | :arrow_down: |
   | [superset/data/bart\_lines.py](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YS9iYXJ0X2xpbmVzLnB5) | `38.46% <0%> (-3.48%)` | :arrow_down: |
   | ... and [39 more](https://codecov.io/gh/apache/incubator-superset/pull/7358/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7358?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7358?src=pr&el=footer). Last update [5f14b55...2b1b757](https://codecov.io/gh/apache/incubator-superset/pull/7358?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org