You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Vincent Massol <vm...@pivolis.com> on 2006/03/31 13:37:31 UTC
RE: [jira] Commented: (MNG-2184) Possible problem with @aggregator and forked lifecycles
> -----Original Message-----
> From: Brett Porter (JIRA) [mailto:jira@codehaus.org]
> Sent: vendredi 31 mars 2006 01:01
> To: vmassol@pivolis.com
> Subject: [jira] Commented: (MNG-2184) Possible problem with @aggregator
> and forked lifecycles
[snip]
> This only happens as part of the site, because it doesn't support using
> @aggregator for reports. I think this is a dupe - I'll search.
>
> This is a feature request, so can't be done for 2.0.4. I'd suggest, for
> this release, that you split into clover:clover and clover:report, with
> the first being @aggregator and not implementing MavenReport, and the
> latter not aggregating and implementing MavenReport.
How would users use it so that when they type "mvn site" it does the full
shebang?
Are you suggesting to bind the clover:clover mojo to the pre-site phase?
How is it going to be triggered automatically? I guess users would need to
add the clover:clover goal to their <build><plugins><plugin> section as an
execution.
I guess this is doable but I'm sure that most users will simply specify a
the plugin in the reporting section and not understand why it's failing
saying that no clover database exists for the project. Of course I could try
putting a nice message and explain that they would need to add an execution
on the clover:clover goal.
Hmm... It could work and it would solve my other issue about having 2 report
mojos. However it's not extremely user-convenient as it requires some config
from them whereas the current solution was real easy. Just type "mvn
clover:clover" and it works without any information in the pom.
> The other thing you can do is to have an isAggregating flag in the clover
> plugin, and set that in the forked lifecycle.
I don't understand this suggestion...
Thanks
-Vincent
___________________________________________________________________________
Nouveau : t�l�phonez moins cher avec Yahoo! Messenger ! D�couvez les tarifs exceptionnels pour appeler la France et l'international.
T�l�chargez sur http://fr.messenger.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [jira] Commented: (MNG-2184) Possible problem with @aggregator and forked lifecycles
Posted by Vincent Massol <vm...@pivolis.com>.
> -----Original Message-----
> From: Vincent Massol [mailto:vmassol@pivolis.com]
> Sent: vendredi 31 mars 2006 17:51
> To: 'Maven Developers List'
> Cc: 'Brett Porter'
> Subject: RE: [jira] Commented: (MNG-2184) Possible problem with
> @aggregator and forked lifecycles
>
>
>
> > -----Original Message-----
> > From: Vincent Massol [mailto:vmassol@pivolis.com]
> > Sent: vendredi 31 mars 2006 15:27
> > To: 'Maven Developers List'
> > Cc: 'Brett Porter'
> > Subject: RE: [jira] Commented: (MNG-2184) Possible problem with
> > @aggregator and forked lifecycles
> >
> > Ok after discussing with Kenney here's the plan:
> >
> > * A clover:instrument goal which forks a custom lifecycle and generate a
> > clover database
> > * All other mojos do not fork a lifecycle. This means users need to
> > specify
> > the instrument goal in an execution in their pom
> > * The clover:check goal simply checks against an existing db
> > * The clover:clover goal (the report) generate a report out of an
> existing
> > db
> >
> > This is actually much better than my initial design as it allows more
> use
> > cases.
> >
> > I'm almost done implementing this...
>
> Actually I hit a wall... The clover:clover goal is not honoring the
> @aggregator annotation and thus the clover databases are not aggregated as
> the top level module is executed *before* its children.
>
> I've then tried to separate the aggregation into a separate module.
> There's
> now a clover:aggregate module which is an aggregator but again running
> "mvn
> site" and binding this aggregation to the pre-site phase does not work for
> some reason.
>
> I'm still investigatin but if anyone has an idea please shoot... All of
> this
> is in svn trunk
Running "mvn clover:instrument clover:aggregate clover:clover" works so
there's really something fishy with the site lifecycle!
What it means is that there's no way to implement this use case right now
:-(. Unless someone has an idea?
Thanks
-Vincent
> > > -----Original Message-----
> > > From: Vincent Massol [mailto:vmassol@pivolis.com]
> > > Sent: vendredi 31 mars 2006 13:38
> > > To: 'Maven Developers List'
> > > Cc: 'Brett Porter'
> > > Subject: RE: [jira] Commented: (MNG-2184) Possible problem with
> > > @aggregator and forked lifecycles
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Brett Porter (JIRA) [mailto:jira@codehaus.org]
> > > > Sent: vendredi 31 mars 2006 01:01
> > > > To: vmassol@pivolis.com
> > > > Subject: [jira] Commented: (MNG-2184) Possible problem with
> > @aggregator
> > > > and forked lifecycles
> > >
> > > [snip]
> > >
> > > > This only happens as part of the site, because it doesn't support
> > using
> > > > @aggregator for reports. I think this is a dupe - I'll search.
> > > >
> > > > This is a feature request, so can't be done for 2.0.4. I'd suggest,
> > for
> > > > this release, that you split into clover:clover and clover:report,
> > with
> > > > the first being @aggregator and not implementing MavenReport, and
> the
> > > > latter not aggregating and implementing MavenReport.
> > >
> > > How would users use it so that when they type "mvn site" it does the
> > full
> > > shebang?
> > >
> > > Are you suggesting to bind the clover:clover mojo to the pre-site
> phase?
> > >
> > > How is it going to be triggered automatically? I guess users would
> need
> > to
> > > add the clover:clover goal to their <build><plugins><plugin> section
> as
> > an
> > > execution.
> > >
> > > I guess this is doable but I'm sure that most users will simply
> specify
> > a
> > > the plugin in the reporting section and not understand why it's
> failing
> > > saying that no clover database exists for the project. Of course I
> could
> > > try
> > > putting a nice message and explain that they would need to add an
> > > execution
> > > on the clover:clover goal.
> > >
> > > Hmm... It could work and it would solve my other issue about having 2
> > > report
> > > mojos. However it's not extremely user-convenient as it requires some
> > > config
> > > from them whereas the current solution was real easy. Just type "mvn
> > > clover:clover" and it works without any information in the pom.
> > >
> > > > The other thing you can do is to have an isAggregating flag in the
> > > clover
> > > > plugin, and set that in the forked lifecycle.
> > >
> > > I don't understand this suggestion...
> > >
> > > Thanks
> > > -Vincent
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> __________________________________________________________________________
> > > _
> > > Nouveau : tiliphonez moins cher avec Yahoo! Messenger ! Dicouvez les
> > > tarifs exceptionnels pour appeler la France et l'international.
> > > Tilichargez sur http://fr.messenger.yahoo.com
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> >
> >
> >
> >
> >
> __________________________________________________________________________
> > _
> > Nouveau : tiliphonez moins cher avec Yahoo! Messenger ! Dicouvez les
> > tarifs exceptionnels pour appeler la France et l'international.
> > Tilichargez sur http://fr.messenger.yahoo.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
>
>
> __________________________________________________________________________
> _
> Nouveau : tiliphonez moins cher avec Yahoo! Messenger ! Dicouvez les
> tarifs exceptionnels pour appeler la France et l'international.
> Tilichargez sur http://fr.messenger.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
___________________________________________________________________________
Nouveau : t�l�phonez moins cher avec Yahoo! Messenger ! D�couvez les tarifs exceptionnels pour appeler la France et l'international.
T�l�chargez sur http://fr.messenger.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [jira] Commented: (MNG-2184) Possible problem with @aggregator and forked lifecycles
Posted by Vincent Massol <vm...@pivolis.com>.
> -----Original Message-----
> From: Vincent Massol [mailto:vmassol@pivolis.com]
> Sent: vendredi 31 mars 2006 15:27
> To: 'Maven Developers List'
> Cc: 'Brett Porter'
> Subject: RE: [jira] Commented: (MNG-2184) Possible problem with
> @aggregator and forked lifecycles
>
> Ok after discussing with Kenney here's the plan:
>
> * A clover:instrument goal which forks a custom lifecycle and generate a
> clover database
> * All other mojos do not fork a lifecycle. This means users need to
> specify
> the instrument goal in an execution in their pom
> * The clover:check goal simply checks against an existing db
> * The clover:clover goal (the report) generate a report out of an existing
> db
>
> This is actually much better than my initial design as it allows more use
> cases.
>
> I'm almost done implementing this...
Actually I hit a wall... The clover:clover goal is not honoring the
@aggregator annotation and thus the clover databases are not aggregated as
the top level module is executed *before* its children.
I've then tried to separate the aggregation into a separate module. There's
now a clover:aggregate module which is an aggregator but again running "mvn
site" and binding this aggregation to the pre-site phase does not work for
some reason.
I'm still investigatin but if anyone has an idea please shoot... All of this
is in svn trunk
Thanks
-Vincent
> > -----Original Message-----
> > From: Vincent Massol [mailto:vmassol@pivolis.com]
> > Sent: vendredi 31 mars 2006 13:38
> > To: 'Maven Developers List'
> > Cc: 'Brett Porter'
> > Subject: RE: [jira] Commented: (MNG-2184) Possible problem with
> > @aggregator and forked lifecycles
> >
> >
> >
> > > -----Original Message-----
> > > From: Brett Porter (JIRA) [mailto:jira@codehaus.org]
> > > Sent: vendredi 31 mars 2006 01:01
> > > To: vmassol@pivolis.com
> > > Subject: [jira] Commented: (MNG-2184) Possible problem with
> @aggregator
> > > and forked lifecycles
> >
> > [snip]
> >
> > > This only happens as part of the site, because it doesn't support
> using
> > > @aggregator for reports. I think this is a dupe - I'll search.
> > >
> > > This is a feature request, so can't be done for 2.0.4. I'd suggest,
> for
> > > this release, that you split into clover:clover and clover:report,
> with
> > > the first being @aggregator and not implementing MavenReport, and the
> > > latter not aggregating and implementing MavenReport.
> >
> > How would users use it so that when they type "mvn site" it does the
> full
> > shebang?
> >
> > Are you suggesting to bind the clover:clover mojo to the pre-site phase?
> >
> > How is it going to be triggered automatically? I guess users would need
> to
> > add the clover:clover goal to their <build><plugins><plugin> section as
> an
> > execution.
> >
> > I guess this is doable but I'm sure that most users will simply specify
> a
> > the plugin in the reporting section and not understand why it's failing
> > saying that no clover database exists for the project. Of course I could
> > try
> > putting a nice message and explain that they would need to add an
> > execution
> > on the clover:clover goal.
> >
> > Hmm... It could work and it would solve my other issue about having 2
> > report
> > mojos. However it's not extremely user-convenient as it requires some
> > config
> > from them whereas the current solution was real easy. Just type "mvn
> > clover:clover" and it works without any information in the pom.
> >
> > > The other thing you can do is to have an isAggregating flag in the
> > clover
> > > plugin, and set that in the forked lifecycle.
> >
> > I don't understand this suggestion...
> >
> > Thanks
> > -Vincent
> >
> >
> >
> >
> >
> >
> >
> __________________________________________________________________________
> > _
> > Nouveau : tiliphonez moins cher avec Yahoo! Messenger ! Dicouvez les
> > tarifs exceptionnels pour appeler la France et l'international.
> > Tilichargez sur http://fr.messenger.yahoo.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
>
>
> __________________________________________________________________________
> _
> Nouveau : tiliphonez moins cher avec Yahoo! Messenger ! Dicouvez les
> tarifs exceptionnels pour appeler la France et l'international.
> Tilichargez sur http://fr.messenger.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
___________________________________________________________________________
Nouveau : t�l�phonez moins cher avec Yahoo! Messenger ! D�couvez les tarifs exceptionnels pour appeler la France et l'international.
T�l�chargez sur http://fr.messenger.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [jira] Commented: (MNG-2184) Possible problem with @aggregator and forked lifecycles
Posted by Vincent Massol <vm...@pivolis.com>.
Ok after discussing with Kenney here's the plan:
* A clover:instrument goal which forks a custom lifecycle and generate a
clover database
* All other mojos do not fork a lifecycle. This means users need to specify
the instrument goal in an execution in their pom
* The clover:check goal simply checks against an existing db
* The clover:clover goal (the report) generate a report out of an existing
db
This is actually much better than my initial design as it allows more use
cases.
I'm almost done implementing this...
Thanks everyone for your help
-Vincent
> -----Original Message-----
> From: Vincent Massol [mailto:vmassol@pivolis.com]
> Sent: vendredi 31 mars 2006 13:38
> To: 'Maven Developers List'
> Cc: 'Brett Porter'
> Subject: RE: [jira] Commented: (MNG-2184) Possible problem with
> @aggregator and forked lifecycles
>
>
>
> > -----Original Message-----
> > From: Brett Porter (JIRA) [mailto:jira@codehaus.org]
> > Sent: vendredi 31 mars 2006 01:01
> > To: vmassol@pivolis.com
> > Subject: [jira] Commented: (MNG-2184) Possible problem with @aggregator
> > and forked lifecycles
>
> [snip]
>
> > This only happens as part of the site, because it doesn't support using
> > @aggregator for reports. I think this is a dupe - I'll search.
> >
> > This is a feature request, so can't be done for 2.0.4. I'd suggest, for
> > this release, that you split into clover:clover and clover:report, with
> > the first being @aggregator and not implementing MavenReport, and the
> > latter not aggregating and implementing MavenReport.
>
> How would users use it so that when they type "mvn site" it does the full
> shebang?
>
> Are you suggesting to bind the clover:clover mojo to the pre-site phase?
>
> How is it going to be triggered automatically? I guess users would need to
> add the clover:clover goal to their <build><plugins><plugin> section as an
> execution.
>
> I guess this is doable but I'm sure that most users will simply specify a
> the plugin in the reporting section and not understand why it's failing
> saying that no clover database exists for the project. Of course I could
> try
> putting a nice message and explain that they would need to add an
> execution
> on the clover:clover goal.
>
> Hmm... It could work and it would solve my other issue about having 2
> report
> mojos. However it's not extremely user-convenient as it requires some
> config
> from them whereas the current solution was real easy. Just type "mvn
> clover:clover" and it works without any information in the pom.
>
> > The other thing you can do is to have an isAggregating flag in the
> clover
> > plugin, and set that in the forked lifecycle.
>
> I don't understand this suggestion...
>
> Thanks
> -Vincent
>
>
>
>
>
>
> __________________________________________________________________________
> _
> Nouveau : tiliphonez moins cher avec Yahoo! Messenger ! Dicouvez les
> tarifs exceptionnels pour appeler la France et l'international.
> Tilichargez sur http://fr.messenger.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
___________________________________________________________________________
Nouveau : t�l�phonez moins cher avec Yahoo! Messenger ! D�couvez les tarifs exceptionnels pour appeler la France et l'international.
T�l�chargez sur http://fr.messenger.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org