You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/25 12:23:16 UTC

[GitHub] [spark] weixiuli opened a new pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

weixiuli opened a new pull request #34711:
URL: https://github.com/apache/spark/pull/34711


   
   ### What changes were proposed in this pull request?
   Avoid unnecessary calculating the number of outstanding fetch requests and RPCS
   
   ### Why are the changes needed?
   It is unnecessary to calculate the number of outstanding fetch requests and RPCS when the IdleStateEvent is not IDLE or the last request is not timeout.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No.
   ### How was this patch tested?
   Exist unittests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34711:
URL: https://github.com/apache/spark/pull/34711#issuecomment-979196872


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34711:
URL: https://github.com/apache/spark/pull/34711#issuecomment-979196872


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #34711:
URL: https://github.com/apache/spark/pull/34711


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] weixiuli commented on pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
weixiuli commented on pull request #34711:
URL: https://github.com/apache/spark/pull/34711#issuecomment-1000111398


   Thanks @srowen @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun removed a comment on pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun removed a comment on pull request #34711:
URL: https://github.com/apache/spark/pull/34711#issuecomment-1006878309


   +1, late LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34711:
URL: https://github.com/apache/spark/pull/34711#issuecomment-1000319526


   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34711:
URL: https://github.com/apache/spark/pull/34711#issuecomment-1006878309


   +1, late LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] weixiuli commented on pull request #34711: [SPARK-37462][CORE] Avoid unnecessary calculating the number of outstanding fetch requests and RPCS

Posted by GitBox <gi...@apache.org>.
weixiuli commented on pull request #34711:
URL: https://github.com/apache/spark/pull/34711#issuecomment-991845661


   Jenkins test this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org