You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/25 23:35:13 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #12088: Add output typehints to GroupIntoBatches

kennknowles commented on a change in pull request #12088:
URL: https://github.com/apache/beam/pull/12088#discussion_r445894084



##########
File path: sdks/python/apache_beam/transforms/util.py
##########
@@ -741,6 +741,7 @@ def WithKeys(pcoll, k):
 
 @experimental()
 @typehints.with_input_types(Tuple[K, V])
+@typehints.with_output_types(Tuple[K, List[V]])

Review comment:
       Correct. It is up to the runner how to implement, but per key and window must be executed serially.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org