You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/03 06:48:10 UTC
[GitHub] [iotdb] cmlmakahts opened a new pull request, #5775: [IOTDB-2919] Delete data/schema region through data/schema state machine
cmlmakahts opened a new pull request, #5775:
URL: https://github.com/apache/iotdb/pull/5775
Interface called by confignode in order to delete data/schema regions at datanodes.
Delete operation works through consensus layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cmlmakahts commented on pull request #5775: [IOTDB-2919] Delete data/schema region through data/schema state machine
Posted by GitBox <gi...@apache.org>.
cmlmakahts commented on PR #5775:
URL: https://github.com/apache/iotdb/pull/5775#issuecomment-1119264373
See pr https://github.com/apache/iotdb/pull/5811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #5775: [IOTDB-2919] Delete data/schema region through data/schema state machine
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on code in PR #5775:
URL: https://github.com/apache/iotdb/pull/5775#discussion_r863684723
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/plan/node/DeleteRegionNode.java:
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.planner.plan.node;
+
+import org.apache.iotdb.common.rpc.thrift.TRegionReplicaSet;
+import org.apache.iotdb.commons.consensus.ConsensusGroupId;
+import org.apache.iotdb.consensus.common.request.IConsensusRequest;
+import org.apache.iotdb.db.mpp.plan.analyze.Analysis;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+
+import java.nio.ByteBuffer;
+import java.util.List;
+
+public class DeleteRegionNode extends WritePlanNode implements IConsensusRequest {
+
Review Comment:
Shall we separate DeleteDataRegionNode and DeleteSchemaRegionNode from this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cmlmakahts closed pull request #5775: [IOTDB-2919] Delete data/schema region through data/schema state machine
Posted by GitBox <gi...@apache.org>.
cmlmakahts closed pull request #5775: [IOTDB-2919] Delete data/schema region through data/schema state machine
URL: https://github.com/apache/iotdb/pull/5775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org