[GitHub] [fineract] DheerajKumar19 commented on a diff in pull request #3260: FINERACT-904 : Post Interest on Account Activation Date for Fixed Dep…

["DheerajKumar19 (via GitHub)" <gi...@apache.org>]

DheerajKumar19 commented on code in PR #3260:
URL: https://github.com/apache/fineract/pull/3260#discussion_r1247262466


##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsHelper.java:
##########
@@ -161,6 +161,8 @@ private LocalDate determineInterestPostingPeriodEndDateFrom(final LocalDate peri
                 }
                 periodEndDate = periodEndDate.with(TemporalAdjusters.lastDayOfMonth());
             break;
+            case ACTIVATIONDATE:

Review Comment:
   @adamsaghy Yes this is going to increment based on the activation day and increments monthly wrt date. As far as naming convention, please guide me here this is my first time around here at Fineract so please feel free to let me know what other changes I need to be doing here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org