You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/03/09 07:00:02 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10518: Fix wrong layer of metric `userError` in DynamoDB monitoring.

wu-sheng commented on code in PR #10518:
URL: https://github.com/apache/skywalking/pull/10518#discussion_r1130561909


##########
oap-server/server-starter/src/main/resources/otel-rules/aws-dynamodb/dynamodb-endpoint.yaml:
##########
@@ -78,8 +78,7 @@ metricsRules:
     exp: amazonaws_com_AWS_DynamoDB_SystemErrors.tagMatch('Operation','GetItem|Scan|Query|BatchGetItem|TransactGetItems')
   - name: endpoint_write_system_errors
     exp: amazonaws_com_AWS_DynamoDB_SystemErrors.tagMatch('Operation','PutItem|UpdateItem|DeleteItem|BatchWriteItem|TransactWriteItems')
-  - name: endpoint_user_errors

Review Comment:
   I can see `User Errors` in the `backend-aws-dynamodb-monitoring.md` doc, should it update as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org