You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/06/07 23:57:58 UTC
[jira] [Created] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
New findbugs warning after MAPREDUCE-2494
-----------------------------------------
Key: MAPREDUCE-2573
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Todd Lipcon
MAPREDUCE-2494 introduced the following findbugs warning in trunk:
TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans reassigned MAPREDUCE-2573:
----------------------------------------------
Assignee: Robert Joseph Evans
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047190#comment-13047190 ]
Robert Joseph Evans commented on MAPREDUCE-2573:
------------------------------------------------
Todd, thanks for catching this and committing it.
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Fix For: 0.23.0
>
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045959#comment-13045959 ]
Robert Joseph Evans commented on MAPREDUCE-2573:
------------------------------------------------
I am not sure why this issue is showing up now because MAPREDUCE-2494 did not modify that part of the code, but it is correct that it should be a static inner class. The change is simple to do, I should have a patch for it very shortly.
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046621#comment-13046621 ]
Robert Joseph Evans commented on MAPREDUCE-2573:
------------------------------------------------
I really don't know what is happening with the contrib and core tests. I only changed a single line to make an inner class static that should be static. Also the precommit 363 build, that Jenkins is pointing us to failed, so it must not be the correct build.
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046908#comment-13046908 ]
Hudson commented on MAPREDUCE-2573:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #720 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/720/])
MAPREDUCE-2573. Fix new findbugs warning introduced by MAPREDUCE-2494. Contributed by Robert Joseph Evans.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134121
Files :
* /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapreduce/filecache/TrackerDistributedCacheManager.java
* /hadoop/mapreduce/trunk/CHANGES.txt
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Fix For: 0.23.0
>
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-2573:
-------------------------------------------
Attachment: MR-2573-mr-trunk-V1.patch
OK I was wrong after looking at the changed I did touch that part of the code with the intention of making it static, but I guess I never did it. This patch fixes that. There are no new tests for it, as it is a very simple change.
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-2573:
-------------------------------------------
Status: Patch Available (was: Open)
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046145#comment-13046145 ]
Hadoop QA commented on MAPREDUCE-2573:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481836/MR-2573-mr-trunk-V1.patch
against trunk revision 1133226.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
org.apache.hadoop.fs.TestFileSystem
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/363//console
This message is automatically generated.
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2573:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Robert.
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Fix For: 0.23.0
>
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2573) New findbugs warning after
MAPREDUCE-2494
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057253#comment-13057253 ]
Hudson commented on MAPREDUCE-2573:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #722 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/])
> New findbugs warning after MAPREDUCE-2494
> -----------------------------------------
>
> Key: MAPREDUCE-2573
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2573
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Todd Lipcon
> Assignee: Robert Joseph Evans
> Fix For: 0.23.0
>
> Attachments: MR-2573-mr-trunk-V1.patch
>
>
> MAPREDUCE-2494 introduced the following findbugs warning in trunk:
> TrackerDistributedCacheManager.java:739, SIC_INNER_SHOULD_BE_STATIC, Priority: Low
> Should org.apache.hadoop.mapreduce.filecache.TrackerDistributedCacheManager$CacheDir be a _static_ inner class?
> This class is an inner class, but does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary. If possible, the class should be made static.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira