You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/11 14:05:17 UTC
[GitHub] [tvm] Mousius opened a new pull request, #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Mousius opened a new pull request, #13363:
URL: https://github.com/apache/tvm/pull/13363
This attempts to replace the CMSIS-NN header with a more portable alternative and avoid dependence on CMSIS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm merged pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
ashutosh-arm merged PR #13363:
URL: https://github.com/apache/tvm/pull/13363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on a diff in pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
Mousius commented on code in PR #13363:
URL: https://github.com/apache/tvm/pull/13363#discussion_r1032656179
##########
python/tvm/topi/arm_cpu/mprofile/dsp/micro_kernel/tensordot.py:
##########
@@ -127,6 +127,19 @@ def tensordot_impl(in_dtype: str, tensor_h: int, jump: int, tensor_w: int, suffi
#include <stdint.h>
#include <arm_acle.h>
+ #ifndef ARM_CPU_ROR_EXISTS
Review Comment:
I think this is OK as @guberti will rewrite this entire file in #13242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm commented on pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
ashutosh-arm commented on PR #13363:
URL: https://github.com/apache/tvm/pull/13363#issuecomment-1372053762
> @Mousius any update on this?
We have started looking at it. I am able to reproduce the hang locally: `test_arm_mprofile_dsp.py::test_conv1d[int16-data_shape_nwc2-3-5-1-0]` that is failing in the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #13363:
URL: https://github.com/apache/tvm/pull/13363#issuecomment-1324966248
The include is removed in #13242, so we can wait for that to land :smile_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13363:
URL: https://github.com/apache/tvm/pull/13363#issuecomment-1371548710
@Mousius any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
Mousius commented on PR #13363:
URL: https://github.com/apache/tvm/pull/13363#issuecomment-1373997208
@mehrdadh I've pushed up a fix for the hanging, it addresses some of the type punning with`memcpy` :smile_cat: see https://github.com/apache/tvm/pull/13363/commits/9af76f061893cc609c3586567a21220426653b86 for more details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13363:
URL: https://github.com/apache/tvm/pull/13363#issuecomment-1311732284
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius closed pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
Posted by GitBox <gi...@apache.org>.
Mousius closed pull request #13363: [microTVM] Replace arm_nnsupportfunctions.h with arm_acle.h
URL: https://github.com/apache/tvm/pull/13363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org