You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Jerry Chen <ha...@intel.com> on 2016/04/01 05:39:45 UTC
Re: Review Request 34086: SENTRY-734: Update
SentryPolicyStoreProcessor for grant user to role
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34086/#review126529
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java (line 145)
<https://reviews.apache.org/r/34086/#comment189550>
Can the name the same with listPrivilegesForProvider?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java (line 240)
<https://reviews.apache.org/r/34086/#comment189551>
Trailing white space. Please remove.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 692)
<https://reviews.apache.org/r/34086/#comment189555>
Use static empty set instance for utils or define by you own.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 726)
<https://reviews.apache.org/r/34086/#comment189556>
The same as to the name "ug".
- Jerry Chen
On May 12, 2015, 7:11 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34086/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 7:11 a.m.)
>
>
> Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update SentryPolicyStoreProcessor for grant user to role
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 7a9f0df
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java 44681ca
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 30792f3
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 02c7535
>
> Diff: https://reviews.apache.org/r/34086/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>