You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/06/29 05:11:31 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #2344: fix: solve config bool field zero value bug by using pointer
codecov-commenter commented on PR #2344:
URL: https://github.com/apache/dubbo-go/pull/2344#issuecomment-1612440213
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2344](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ce0c626) into [main](https://app.codecov.io/gh/apache/dubbo-go/commit/95b463b35b1b11b5d980e3b386382486da84ad5d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (95b463b) will **increase** coverage by `0.00%`.
> The diff coverage is `79.06%`.
> :exclamation: Current head ce0c626 differs from pull request most recent head 9e000fa. Consider uploading reports for the commit 9e000fa to get more accurate results
```diff
@@ Coverage Diff @@
## main #2344 +/- ##
=======================================
Coverage 44.10% 44.10%
=======================================
Files 294 295 +1
Lines 17890 17933 +43
=======================================
+ Hits 7890 7909 +19
- Misses 9161 9180 +19
- Partials 839 844 +5
```
| [Impacted Files](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [cluster/router/tag/match.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL21hdGNoLmdv) | `75.58% <0.00%> (-15.12%)` | :arrow_down: |
| [config/provider\_config.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `45.92% <ø> (ø)` | |
| [config/tracing\_config.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3RyYWNpbmdfY29uZmlnLmdv) | `66.66% <ø> (ø)` | |
| [filter/metrics/filter.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `73.91% <0.00%> (-11.09%)` | :arrow_down: |
| [protocol/dubbo3/dubbo3\_invoker.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19pbnZva2VyLmdv) | `58.33% <0.00%> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `56.02% <0.00%> (ø)` | |
| [cluster/router/tag/router.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlci5nbw==) | `56.89% <50.00%> (-2.76%)` | :arrow_down: |
| [metrics/prometheus/after\_invocation.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9wcm9tZXRoZXVzL2FmdGVyX2ludm9jYXRpb24uZ28=) | `69.23% <71.42%> (-25.06%)` | :arrow_down: |
| [metrics/prometheus/before\_invocation.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9wcm9tZXRoZXVzL2JlZm9yZV9pbnZvY2F0aW9uLmdv) | `77.77% <77.77%> (ø)` | |
| [metrics/prometheus/reporter.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `66.66% <80.00%> (+13.33%)` | :arrow_up: |
| ... and [4 more](https://app.codecov.io/gh/apache/dubbo-go/pull/2344?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-go/pull/2344/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org