You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/04 15:11:24 UTC

[GitHub] [hbase] Apache9 commented on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

Apache9 commented on pull request #3899:
URL: https://github.com/apache/hbase/pull/3899#issuecomment-986042904


   I think the intention here is that, for a memstore snapshot, it will never change, so we do not need to create a scanner for it every time, just reuse the same one.
   
   So here, I prefer we introduce a DelegateKeyValueScanner, which will delegate all the methods to the segment scanner, except the close method. And once the snapshot itself is closed, we will call the close method of the actual segment scanners.
   
   WDYT?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org