You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/11/13 14:16:30 UTC
[PR] KAFKA-18006: Add 3.9.0 to end-to-end test [kafka]
frankvicky opened a new pull request, #17797:
URL: https://github.com/apache/kafka/pull/17797
JIRA: KAFKA-18006
Since 3.9 is released, we should add it to the e2e-test.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17797:
URL: https://github.com/apache/kafka/pull/17797#issuecomment-2475807412
overall LGTM. I'm testing following changed e2e with this PR.
tests/kafkatest/tests/core/transactions_upgrade_test.py
tests/kafkatest/tests/core/transactions_mixed_versions_test.py
tests/kafkatest/tests/core/downgrade_test.py
tests/kafkatest/tests/core/kraft_upgrade_test.py
tests/kafkatest/tests/core/compatibility_test_new_broker_test.py
tests/kafkatest/tests/client/client_compatibility_features_test.py
tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py
tests/kafkatest/tests/client/consumer_protocol_migration_test.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #17797:
URL: https://github.com/apache/kafka/pull/17797#issuecomment-2474156464
Run `client_compatibility_produce_consume_test.py` for validate purpose, and get following fails:
```
FAILED TEST SYMBOLS
Pass the test symbols below to your ducktape run
'tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py::ClientCompatibilityProduceConsumeTest.test_produce_consume@{"broker_version":"2.1.1"}' 'tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py::ClientCompatibilityProduceConsumeTest.test_produce_consume@{"broker_version":"2.2.2"}' 'tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py::ClientCompatibilityProduceConsumeTest.test_produce_consume@{"broker_version":"2.3.1"}'
ducker-ak test failed
```
These fails are handled by #17625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1840695913
##########
tests/kafkatest/services/zookeeper.py:
##########
@@ -45,7 +45,7 @@ class ZookeeperService(KafkaPathResolverMixin, Service):
# After 4.0, zookeeper service is removed from source code. Using LATEST_3_8 for compatibility test cases.
Review Comment:
nit.
LATEST_3_8 -> LATEST_3_9 in this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841886776
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
With this new matrix, we run quite some more tests. I am not sure, if it was set the old way to NOT run so many tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841895134
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
It will bring addition test for "PLAINTEXT" protocol ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841839022
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
Do we not test with `none` and `static_membership` anymore?
I see that 3.8 also misses that parametrization. 3.7 has it, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #17797:
URL: https://github.com/apache/kafka/pull/17797#issuecomment-2473938621
@frankvicky Please add the 3.9 to dockerfile and vagrant. Otherwise, e2e has no 3.9 binary to run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841950926
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
As far as I understand the notation (I might be wrong since I am not too familiar with this), the old parametrization
```
@parametrize(version=str(LATEST_3_7), compression_types=["snappy"])
@parametrize(version=str(LATEST_3_7), compression_types=["zstd"], security_protocol="SASL_SSL")
@matrix(version=[str(LATEST_3_7)], compression_types=[["none"]], static_membership=[False, True])
```
runs for each version:
snappy, plaintext, static_membership=False
zstd, sasl_ssl, static_membership=False
none, plaintext, static_membership=False
none, plaintext, static_membership=True
The new parametrization
```
@matrix(version=[str(LATEST_2_5), str(LATEST_2_6), str(LATEST_2_7), str(LATEST_2_8), str(LATEST_3_0),
str(LATEST_3_1), str(LATEST_3_2), str(LATEST_3_3), str(LATEST_3_4), str(LATEST_3_5),
str(LATEST_3_6), str(LATEST_3_7), str(LATEST_3_8), str(LATEST_3_9)],
compression_types=[["none"], ["zstd"], ["snappy"]],
security_protocols=["SASL_SSL", "PLAINTEXT"],
static_membership=[False, True]
)
```
runs for each version:
snappy, plaintext, static_membership=False
snappy, plaintext, static_membership=True
snappy, sasl_ssl, static_membership=False
snappy, sasl_ssl, static_membership=True
zstd, plaintext, static_membership=False
zstd, plaintext, static_membership=True
zstd, sasl_ssl, static_membership=False
zstd, sasl_ssl, static_membership=True
none, plaintext, static_membership=False
none, plaintext, static_membership=True
none, sasl_ssl, static_membership=False
none, sasl_ssl, static_membership=True
This is three times more tests per version. I am wondering, if the intend of the old parametrization was to NOT run so many tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841985903
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
> This is three times more tests per version. I am wondering, if the intend of the old parametrization was to NOT run so many tests.
Maybe we can remove snappy? or using the origin style is fine to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841994546
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
> I think old style is more suitable for current situation.
I will update it later.
Yeah, I agree!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841868061
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
Perhaps we should use `matrix` to include those test suites.
```
@matrix(version=[str(LATEST_2_5), str(LATEST_2_6), str(LATEST_2_7), str(LATEST_2_8), str(LATEST_3_0),
str(LATEST_3_1), str(LATEST_3_2), str(LATEST_3_3), str(LATEST_3_4), str(LATEST_3_5),
str(LATEST_3_6), str(LATEST_3_7), str(LATEST_3_8), str(LATEST_3_9)],
compression_types=[["none"], ["zstd"], ["snappy"]],
security_protocols=["SASL_SSL", PLAINTEXT],
static_membership=[False, True]
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841873444
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
Thank you for pointing that out!
I made changes in this PR based on the 3.8 one, so I believe this was missed in 3.8 and unintentionally carried over here. 😬
I’ll add it for both 3.8 and 3.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #17797:
URL: https://github.com/apache/kafka/pull/17797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1840779166
##########
tests/kafkatest/services/zookeeper.py:
##########
@@ -45,7 +45,7 @@ class ZookeeperService(KafkaPathResolverMixin, Service):
# After 4.0, zookeeper service is removed from source code. Using LATEST_3_8 for compatibility test cases.
Review Comment:
Thanks for pointing out. 😺
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18006: Add 3.9.0 to end-to-end test (core, client) [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841992269
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"], security_protocol="SASL_SSL")
Review Comment:
I think old style is more suitable for current situation.
I will update it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org