You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/26 21:53:35 UTC

[GitHub] [airflow] bbovenzi opened a new pull request #15043: improve react-query testing

bbovenzi opened a new pull request #15043:
URL: https://github.com/apache/airflow/pull/15043


   Improving how we test components that include API requests
   
   - simplify react-query actions on test environments
   - before set ups and `afterAll` clean ups
   - add missing async/await
   - add a dummy url to mock requests
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on a change in pull request #15043: improve react-query testing

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on a change in pull request #15043:
URL: https://github.com/apache/airflow/pull/15043#discussion_r602605145



##########
File path: airflow/ui/jest.config.js
##########
@@ -23,5 +23,6 @@
 const neutrino = require('neutrino');
 
 process.env.NODE_ENV = process.env.NODE_ENV || 'test';
+process.env.WEBSERVER_URL = process.env.WEBSERVER_URL || 'http://localhost:9999';

Review comment:
       @ashb curious to get your opinion on if we should do this or have a fully separate test environment
   
   We just need some sort of realistic url.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #15043: improve react-query testing

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #15043:
URL: https://github.com/apache/airflow/pull/15043#discussion_r602775903



##########
File path: airflow/ui/jest.config.js
##########
@@ -23,5 +23,6 @@
 const neutrino = require('neutrino');
 
 process.env.NODE_ENV = process.env.NODE_ENV || 'test';
+process.env.WEBSERVER_URL = process.env.WEBSERVER_URL || 'http://localhost:9999';

Review comment:
       By test environment what do you mean by a separate env? Like a full running instance? 
   
   If this is just for mocked URLs then this is fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on a change in pull request #15043: improve react-query testing

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on a change in pull request #15043:
URL: https://github.com/apache/airflow/pull/15043#discussion_r602795489



##########
File path: airflow/ui/jest.config.js
##########
@@ -23,5 +23,6 @@
 const neutrino = require('neutrino');
 
 process.env.NODE_ENV = process.env.NODE_ENV || 'test';
+process.env.WEBSERVER_URL = process.env.WEBSERVER_URL || 'http://localhost:9999';

Review comment:
       Yep. just mocks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton merged pull request #15043: improve react-query testing

Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #15043:
URL: https://github.com/apache/airflow/pull/15043


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #15043: improve react-query testing

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15043:
URL: https://github.com/apache/airflow/pull/15043#issuecomment-808720197


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org