You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jake Farrell (Closed) (JIRA)" <ji...@apache.org> on 2011/12/08 22:17:40 UTC
[jira] [Closed] (THRIFT-1452) generate a swap() method for all
generated structs
[ https://issues.apache.org/jira/browse/THRIFT-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1452.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.9
Assignee: Dave Watson
Thanks Dave, committed
> generate a swap() method for all generated structs
> ---------------------------------------------------
>
> Key: THRIFT-1452
> URL: https://issues.apache.org/jira/browse/THRIFT-1452
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 0003-thrift-generate-a-swap-method-for-all-generated-stru.patch
>
>
> From baa275da65e023af50930a75f9a7ef2a991cdaef Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 21 Jun 2010 20:24:50 +0000
> Subject: [PATCH 3/5] generate a swap() method for all generated structs
> Summary:
> Andrei mentioned it would be convenient if thrift generated swap()
> methods for all C++ thrift types. Apparently the ads team manually
> writes swap() functions for many of their thrift data types, but have to
> keep updating them by hand when new fields are added to the thrift
> interface.
> This updates the thrift compiler to emit swap() methods for user-defined
> types. For now, I decided not to emit swap() methods for the internal
> XXX_args, XXX_pargs, XXX_result, and XXX_presult types.
> Test Plan:
> Tested compiling serveral internal projects.
> I didn't actually test the generated swap() functions, but they look
> okay.
> DiffCamp Revision: 124773
> Reviewed By: aalexandre
> Commenters: dreiss, edhall
> CC: davidrecordon, achao, dreiss, kholst, aalexandre, simpkins, edhall,
> thrift-team@lists
> Revert Plan:
> OK
> git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@30392 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
> ---
> compiler/cpp/src/generate/t_cpp_generator.cc | 70 ++++++++++++++++++++++++-
> 1 files changed, 67 insertions(+), 3 deletions(-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira