You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "VishalMCF (via GitHub)" <gi...@apache.org> on 2024/04/08 07:37:33 UTC
[PR] added test cases for threadUtils class (eventmesh)
VishalMCF opened a new pull request, #4818:
URL: https://github.com/apache/eventmesh/pull/4818
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #issue_id
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2056916043
>failing because of the randomized test case
You can absolutely make changes to other test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] added test cases for threadUtils class (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2042459127
Kindly refer to the standard title format used in other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4540] Add test cases for ThreadUtils class (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2053981661
@VishalMCF Please check CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 (eventmesh)
Posted by "VishalMCF (via GitHub)" <gi...@apache.org>.
VishalMCF commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2056754146
@Pil0tXia I checked it is failing because of the randomized test case. Its failing during build. ALthough on my local machine it passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 (eventmesh)
Posted by "VishalMCF (via GitHub)" <gi...@apache.org>.
VishalMCF commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2054182816
@Pil0tXia I ran the checkstyle plugin. But the file which i worked on is now fixed as per the results. But there is another file -> Execution failed for task ':eventmesh-protocol-plugin:eventmesh-protocol-grpc:generateProto'.
> protoc: stdout: . stderr: /Users/vishalyadav/.gradle/caches/modules-2/files-2.1/io.grpc/protoc-gen-grpc-java/1.43.2/d1f6199ad60848a873bd14fc8deefc6733b75586/protoc-gen-grpc-java-1.43.2-osx-aarch_64.exe: program not found or is not executable
Please specify a program using absolute path or make sure the program is available in your PATH system variable
--grpc_out: protoc-gen-grpc: Plugin failed with status code 1.
This is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2054082553
@VishalMCF Please be informed that the CI still failed. You may refer to https://eventmesh.apache.org/zh/community/contribute/contribute for help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2055690426
@VishalMCF
I re-ran the failed task of CI and it is still failing.
May you please check [debug log](https://github.com/apache/eventmesh/actions/runs/8680910282/job/23812602913?pr=4818) for detailed information?
---
The log you reported about ':eventmesh-protocol-plugin:eventmesh-protocol-grpc:generateProto' seems to be a dependency installation problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540 (eventmesh)
Posted by "VishalMCF (via GitHub)" <gi...@apache.org>.
VishalMCF closed pull request #4818: [ISSUE #4540] [Unit Test] Unit test for ThreadUtils #4540
URL: https://github.com/apache/eventmesh/pull/4818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] added test cases for threadUtils class (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4818:
URL: https://github.com/apache/eventmesh/pull/4818#issuecomment-2042486953
plz check ci~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org