You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/04 18:00:45 UTC

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1633: feat: add the service page upstream select option

liuxiran commented on pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-813073868


   > > Hi @guoqqqi
   > > Update the commit, I change the LINE#92
   > > ```js
   > > cy.contains('None').should('be.visible');
   > > ```
   > 
   > No, What I mean is that the data upstream of the creation of the service is now lost when editing.
   
   Hi @stu01509, you can try to add `setHiddenForm(false);`  after line https://github.com/apache/apisix-dashboard/pull/1633/files#diff-0029901a283985aea1e8e47cfb2d45c9c8eef8cb392e12ed31720390a22ec269L641
   
   so that when the `upstream_id` changed along with the `form` props  in the `UpstreamForm` component, `hiddenForm` state can change together with the right logic.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org