[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15187: Improve static cached_op optimization

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #15187: Improve static cached_op optimization
URL: https://github.com/apache/incubator-mxnet/pull/15187#discussion_r292668526
 
 

 ##########
 File path: src/imperative/cached_op.cc
 ##########
 @@ -290,7 +290,7 @@ bool CachedOp::CheckDynamicShapeExists(const Context& default_ctx,
   CheckAndInferShape(&g, std::move(shape_inputs), true,
                      {0, 0}, {0, 0},
                      &contain_dynamic_shape);
-  if (contain_dynamic_shape && erase_result) {
+  if (!config_.static_shape && erase_result) {
 
 Review comment:
   Sounds like something wasn't properly tested here? Maybe add a test to cover this path?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services