You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/26 09:24:19 UTC
[GitHub] [inlong] Oneal65 opened a new pull request, #5717: [INLONG-5712][Sort] Fix class not found in Elasticsearch 6 connector for producting
Oneal65 opened a new pull request, #5717:
URL: https://github.com/apache/inlong/pull/5717
- Fixes #5712
### Motivation
Fix class not found in Elasticsearch 6 connector for producting
### Modifications
modify some poms and add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5717: [INLONG-5712][Sort] Fix class not found in Elasticsearch 6 connector for producting
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5717:
URL: https://github.com/apache/inlong/pull/5717#discussion_r956752942
##########
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/ElasticsearchSqlParseTest.java:
##########
@@ -59,7 +58,7 @@ private MySqlExtractNode buildMysqlExtractNode() {
true, null);
}
- private ElasticsearchLoadNode buildElasticsearchLoadNode() {
+ ElasticsearchLoadNode buildElasticsearchLoadNode(int i) {
Review Comment:
OK, I will modify it. it means version number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5717: [INLONG-5712][Sort] Fix class not found in Elasticsearch 6 connector for producting
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5717:
URL: https://github.com/apache/inlong/pull/5717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5717: [INLONG-5712][Sort] Fix class not found in Elasticsearch 6 connector for producting
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5717:
URL: https://github.com/apache/inlong/pull/5717#discussion_r956557270
##########
inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/ElasticsearchSqlParseTest.java:
##########
@@ -59,7 +58,7 @@ private MySqlExtractNode buildMysqlExtractNode() {
true, null);
}
- private ElasticsearchLoadNode buildElasticsearchLoadNode() {
+ ElasticsearchLoadNode buildElasticsearchLoadNode(int i) {
Review Comment:
The parameter `i` is not understood easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org