You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/20 18:55:58 UTC

[GitHub] [spark] Tagar commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

Tagar commented on pull request #29342:
URL: https://github.com/apache/spark/pull/29342#issuecomment-713070936


   @c21 thanks for this great improvement - quick question on this
   https://github.com/apache/spark/pull/29342#discussion_r469568896
   
   >> Btw, is it worth testing with shuffle partitions = 1 ?
   > 
   > I don't think so, as if there's only one shuffle partition, 
   > we should use broadcast hash join instead.
   
   `BHJ` doesn't support full outer join currently. Would it be possible to improve `BHJ` similarly to support `full outer join` as it's done here for `SHJ`? Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org