You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kevinjmh <gi...@git.apache.org> on 2018/11/05 09:31:35 UTC
[GitHub] carbondata pull request #2894: [CARBONDATA-3074] Change default sort temp co...
GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2894
[CARBONDATA-3074] Change default sort temp compressor to SNAPPY
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevinjmh/carbondata sorttempDefault
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2894.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2894
----
commit 7877c797230b58fd4c51ffa21a026bc13493ac1f
Author: Manhua <ke...@...>
Date: 2018-11-05T09:28:07Z
change default sort temp compressor from empty to snappy
----
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2894
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1483/
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2894
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1268/
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by kevinjmh <gi...@git.apache.org>.
Github user kevinjmh commented on the issue:
https://github.com/apache/carbondata/pull/2894
retest this please
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2894
please add description in the PR
```
Some experiments in local cluster shows that setting the compressor ‘snappy’ will slightly enhance the loading performance and reduce lots of disk IO during data loading.
```
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2894
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9536/
---
[GitHub] carbondata pull request #2894: [CARBONDATA-3074] Change default sort temp co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2894
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2894
LGTM
waiting for the build
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2894
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9532/
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2894
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1271/
---
[GitHub] carbondata issue #2894: [CARBONDATA-3074] Change default sort temp compresso...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2894
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1487/
---