[PATCH] Re: svn commit: rev 3311 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client trunk/subversion/tests/clients/cmdline trunk/subversion/tests

[Brian Denny <br...@briandenny.net>]

> It seems the 'posix-only' portions of the test are small enough
> to just be conditional pieces of a generic test that should run
> everywhere.

the attached patch reverts the 'kappa' change, and instead has import
in a single test.  i took your advice and made the test generic: it
does the import regardless of platform, but only concerns itself with
executable-ness on posix.

the *add_executable tests in schedule.py (which didn't use 'kappa') are
left unchanged; they return success immediately on non-posix platforms.
if you dislike this, let me know and i can try to do something about it.

(i tend to think of tests as something that you run and watch for
failures, so a success-via-no-op doesn't bother me.)


> But whatever.  You supply the patch, we'll supply the criticism. :-)

looking forward to said criticism... :)

-brian

Re: [PATCH] Re: svn commit: rev 3311 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/libsvn_client trunk/subversion/tests/clients/cmdline trunk/subversion/tests

[Branko Čibej <br...@xbc.nu>]

Brian Denny wrote:

>  
>
>>It seems the 'posix-only' portions of the test are small enough
>>to just be conditional pieces of a generic test that should run
>>everywhere.
>>    
>>
>
>the attached patch reverts the 'kappa' change, and instead has import
>in a single test.  i took your advice and made the test generic: it
>does the import regardless of platform, but only concerns itself with
>executable-ness on posix.
>
>the *add_executable tests in schedule.py (which didn't use 'kappa') are
>left unchanged; they return success immediately on non-posix platforms.
>if you dislike this, let me know and i can try to do something about it.
>
>(i tend to think of tests as something that you run and watch for
>failures, so a success-via-no-op doesn't bother me.)
>
>
>  
>
>>But whatever.  You supply the patch, we'll supply the criticism. :-)
>>    
>>
>
>looking forward to said criticism... :)
>  
>
Don't have any. Sure, we could still split basic_import in two -- but 
lets do that after I've got the SKIP infrastructure in. I'll commit this 
soon.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org