[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #966: Fix visible metadata, version, work processor bugs when recovering

[GitBox <gi...@apache.org>]

HTHou commented on a change in pull request #966: Fix visible metadata, version, work processor bugs when recovering
URL: https://github.com/apache/incubator-iotdb/pull/966#discussion_r401082730
 
 

 ##########
 File path: tsfile/src/main/java/org/apache/iotdb/tsfile/write/writer/TsFileIOWriter.java
 ##########
 @@ -65,14 +66,19 @@
   }
 
   protected TsFileOutput out;
-  protected List<Pair<String, List<ChunkMetadata>>> chunkGroupInfoList = new ArrayList<>();
   protected boolean canWrite = true;
   protected int totalChunkNum = 0;
   protected int invalidChunkNum;
   protected File file;
-  protected List<ChunkMetadata> chunkMetadataList = new ArrayList<>();
-  protected Map<Path, List<ChunkMetadata>> chunkMetadataListMap = new TreeMap<>();
+
+
+  // current flushed Chunk
   private ChunkMetadata currentChunkMetadata;
+  // current flushed ChunkGroup
+  protected List<ChunkMetadata> chunkMetadataList = new ArrayList<>();
+  // all flushed ChunkGroup,  device -> List<ChunkMetadata>
+  protected List<Pair<String, List<ChunkMetadata>>> chunkGroupMetadataList = new ArrayList<>();
+
 
 Review comment:
   Since Pair<String, List<ChunkMetadata> is similar to previous ChunkGroupMetadata, I'm thinking if it's necessary to add ChunkGroupMetadata back instead of using the pair. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services