You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rc...@apache.org on 2020/08/17 09:11:25 UTC

[james-project] 14/26: [Refactoring] Migrate UsersRepositoryManagementTest to JUnit5

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 2026d325ad60e1c754ac36f5c88f94aceb19fcc2
Author: Rene Cordier <rc...@linagora.com>
AuthorDate: Thu Aug 13 15:30:47 2020 +0700

    [Refactoring] Migrate UsersRepositoryManagementTest to JUnit5
---
 .../user/memory/UsersRepositoryManagementTest.java | 26 +++++++++++-----------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/server/data/data-memory/src/test/java/org/apache/james/user/memory/UsersRepositoryManagementTest.java b/server/data/data-memory/src/test/java/org/apache/james/user/memory/UsersRepositoryManagementTest.java
index fb7fa30..89a998e 100644
--- a/server/data/data-memory/src/test/java/org/apache/james/user/memory/UsersRepositoryManagementTest.java
+++ b/server/data/data-memory/src/test/java/org/apache/james/user/memory/UsersRepositoryManagementTest.java
@@ -28,17 +28,17 @@ import org.apache.james.core.Username;
 import org.apache.james.domainlist.api.DomainList;
 import org.apache.james.user.api.UsersRepository;
 import org.apache.james.user.lib.UsersRepositoryManagement;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
-public class UsersRepositoryManagementTest {
-    private static final DomainList NO_DOMAIN_LIST = null;
+class UsersRepositoryManagementTest {
+    static final DomainList NO_DOMAIN_LIST = null;
 
-    private UsersRepository usersRepository;
-    private UsersRepositoryManagement userManagement;
+    UsersRepository usersRepository;
+    UsersRepositoryManagement userManagement;
 
-    @Before
-    public void setUp() throws Exception {
+    @BeforeEach
+    void setUp() throws Exception {
         usersRepository = MemoryUsersRepository.withoutVirtualHosting(NO_DOMAIN_LIST);
 
         userManagement = new UsersRepositoryManagement();
@@ -46,7 +46,7 @@ public class UsersRepositoryManagementTest {
     }
 
     @Test
-    public void testUserCount() throws Exception {
+    void testUserCount() throws Exception {
         assertThat(userManagement.countUsers()).describedAs("no user yet").isEqualTo(0);
         usersRepository.addUser(Username.of("testcount1"), "testCount");
         assertThat(userManagement.countUsers()).describedAs("1 user").isEqualTo(1);
@@ -57,7 +57,7 @@ public class UsersRepositoryManagementTest {
     }
 
     @Test
-    public void testAddUserAndVerify() throws Exception {
+    void testAddUserAndVerify() throws Exception {
         usersRepository.addUser(Username.of("testcount1"), "testCount");
         assertThat(userManagement.verifyExists("testNotAdded")).describedAs("user not there").isFalse();
         assertThat(userManagement.verifyExists("testCount1")).describedAs("user is there").isTrue();
@@ -66,7 +66,7 @@ public class UsersRepositoryManagementTest {
     }
 
     @Test
-    public void testDelUser() throws Exception {
+    void testDelUser() throws Exception {
         usersRepository.addUser(Username.of("testdel"), "test");
         assertThat(userManagement.verifyExists("testNotDeletable")).describedAs("user not there").isFalse();
         assertThat(userManagement.verifyExists("testdel")).describedAs("user is there").isTrue();
@@ -75,7 +75,7 @@ public class UsersRepositoryManagementTest {
     }
 
     @Test
-    public void testListUsers() throws Exception {
+    void testListUsers() throws Exception {
         Username[] usersArray = new Username[]{Username.of("ccc"), Username.of("aaa"), Username.of("dddd"), Username.of("bbbbb")};
         List<Username> users = Arrays.asList(usersArray);
 
@@ -94,7 +94,7 @@ public class UsersRepositoryManagementTest {
     }
 
     @Test
-    public void testSetPassword() throws Exception {
+    void testSetPassword() throws Exception {
         userManagement.addUser("testpwduser", "pwd1");
 
         assertThat(usersRepository.test(Username.of("testpwduser"), "pwd1")).describedAs("initial password").isTrue();


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org