You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/07/29 13:20:49 UTC

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu opened a new pull request #2: SLING-10680 - Add support for versioning partials

raducotescu opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2


   * partials can optionally provide a version, which can now also be used for REQUIRES


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu commented on a change in pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679750345



##########
File path: src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
##########
@@ -48,12 +47,24 @@
         TYPES
     }
 
-    /** The name of this partial */
-    @NotNull String getName();
+    /**
+     * Returns the partial info.
+     *
+     * @return the partial info
+     */
+    @NotNull PartialInfo getPartialInfo();
 
     /** Return a specific section of the partial, by name */
     @NotNull Optional<Section> getSection(SectionName name);
 
     /** Names of the Partials on which this one depends */
-    @NotNull Set<String> getRequiredPartialNames();
+    @NotNull Set<PartialInfo> getRequiredPartialNames();
+
+    /**
+     * Returns the SHA256 hash of the source that was used to build this partial.
+     *
+     * @return the SHA256 hash of the source that was used to build this partial
+     */
+    @NotNull String getSHA256Hash();

Review comment:
       I was initially thinking that two partials should be equal irrespective of where they are coming from and hence wanted to force the various implementations to use the same hash algorithm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] sonarcloud[bot] removed a comment on pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889140996


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![85.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '85.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list) [85.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu commented on a change in pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r683531294



##########
File path: src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
##########
@@ -48,12 +47,24 @@
         TYPES
     }
 
-    /** The name of this partial */
-    @NotNull String getName();
+    /**
+     * Returns the partial info.
+     *
+     * @return the partial info
+     */
+    @NotNull PartialInfo getPartialInfo();
 
     /** Return a specific section of the partial, by name */
     @NotNull Optional<Section> getSection(SectionName name);
 
     /** Names of the Partials on which this one depends */
-    @NotNull Set<String> getRequiredPartialNames();
+    @NotNull Set<PartialInfo> getRequiredPartialNames();
+
+    /**
+     * Returns the SHA256 hash of the source that was used to build this partial.
+     *
+     * @return the SHA256 hash of the source that was used to build this partial
+     */
+    @NotNull String getSHA256Hash();

Review comment:
       Implemented in https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2/commits/7a2bba8c5e9321212e6d5708563c4fe169ebe589.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu merged pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
raducotescu merged pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] sonarcloud[bot] commented on pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-893527721


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![86.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '86.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list) [86.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu commented on pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
raducotescu commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889731364


   I was initially thinking that two partials should be equal irrespective of
   where they are coming from and hence wanted to force the various
   implementations to use the same hash algorithm.
   
   On Fri, 30 Jul 2021 at 10:21, Bertrand Delacretaz ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
   > <https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679743344>
   > :
   >
   > >
   >      /** Return a specific section of the partial, by name */
   >      @NotNull Optional<Section> getSection(SectionName name);
   >
   >      /** Names of the Partials on which this one depends */
   > -    @NotNull Set<String> getRequiredPartialNames();
   > +    @NotNull Set<PartialInfo> getRequiredPartialNames();
   > +
   > +    /**
   > +     * Returns the SHA256 hash of the source that was used to build this partial.
   > +     *
   > +     * @return the SHA256 hash of the source that was used to build this partial
   > +     */
   > +    @NotNull String getSHA256Hash();
   >
   > Shouldn't the name just be getDigest? The algorithm used is an
   > implementation detail IMHO
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#pullrequestreview-718839059>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AABJXH6Y7STAKTUST2ZY2SLT2JOJPANCNFSM5BGOWESQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] sonarcloud[bot] commented on pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889181474


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![86.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '86.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list) [86.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu commented on a change in pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679878099



##########
File path: src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
##########
@@ -48,12 +47,24 @@
         TYPES
     }
 
-    /** The name of this partial */
-    @NotNull String getName();
+    /**
+     * Returns the partial info.
+     *
+     * @return the partial info
+     */
+    @NotNull PartialInfo getPartialInfo();
 
     /** Return a specific section of the partial, by name */
     @NotNull Optional<Section> getSection(SectionName name);
 
     /** Names of the Partials on which this one depends */
-    @NotNull Set<String> getRequiredPartialNames();
+    @NotNull Set<PartialInfo> getRequiredPartialNames();
+
+    /**
+     * Returns the SHA256 hash of the source that was used to build this partial.
+     *
+     * @return the SHA256 hash of the source that was used to build this partial
+     */
+    @NotNull String getSHA256Hash();

Review comment:
       Let's do it like this then, because it's the best compromise: we call the method `getDigest / getHash` but we force implementations to provide the output in this format:
   ```
   algorithm: hash
   ```
   
   This way two partials can be the same irrespective of their provider if the various implementations hash the source in the same way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] bdelacretaz commented on a change in pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679743344



##########
File path: src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
##########
@@ -48,12 +47,24 @@
         TYPES
     }
 
-    /** The name of this partial */
-    @NotNull String getName();
+    /**
+     * Returns the partial info.
+     *
+     * @return the partial info
+     */
+    @NotNull PartialInfo getPartialInfo();
 
     /** Return a specific section of the partial, by name */
     @NotNull Optional<Section> getSection(SectionName name);
 
     /** Names of the Partials on which this one depends */
-    @NotNull Set<String> getRequiredPartialNames();
+    @NotNull Set<PartialInfo> getRequiredPartialNames();
+
+    /**
+     * Returns the SHA256 hash of the source that was used to build this partial.
+     *
+     * @return the SHA256 hash of the source that was used to build this partial
+     */
+    @NotNull String getSHA256Hash();

Review comment:
       Shouldn't the name just be `getDigest`? The algorithm used is an implementation detail IMHO




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu removed a comment on pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
raducotescu removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889731364


   I was initially thinking that two partials should be equal irrespective of
   where they are coming from and hence wanted to force the various
   implementations to use the same hash algorithm.
   
   On Fri, 30 Jul 2021 at 10:21, Bertrand Delacretaz ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
   > <https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679743344>
   > :
   >
   > >
   >      /** Return a specific section of the partial, by name */
   >      @NotNull Optional<Section> getSection(SectionName name);
   >
   >      /** Names of the Partials on which this one depends */
   > -    @NotNull Set<String> getRequiredPartialNames();
   > +    @NotNull Set<PartialInfo> getRequiredPartialNames();
   > +
   > +    /**
   > +     * Returns the SHA256 hash of the source that was used to build this partial.
   > +     *
   > +     * @return the SHA256 hash of the source that was used to build this partial
   > +     */
   > +    @NotNull String getSHA256Hash();
   >
   > Shouldn't the name just be getDigest? The algorithm used is an
   > implementation detail IMHO
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#pullrequestreview-718839059>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AABJXH6Y7STAKTUST2ZY2SLT2JOJPANCNFSM5BGOWESQ>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] sonarcloud[bot] commented on pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889140996


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![85.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '85.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list) [85.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] raducotescu commented on a change in pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
raducotescu commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#discussion_r679750345



##########
File path: src/main/java/org/apache/sling/graphql/schema/aggregator/impl/Partial.java
##########
@@ -48,12 +47,24 @@
         TYPES
     }
 
-    /** The name of this partial */
-    @NotNull String getName();
+    /**
+     * Returns the partial info.
+     *
+     * @return the partial info
+     */
+    @NotNull PartialInfo getPartialInfo();
 
     /** Return a specific section of the partial, by name */
     @NotNull Optional<Section> getSection(SectionName name);
 
     /** Names of the Partials on which this one depends */
-    @NotNull Set<String> getRequiredPartialNames();
+    @NotNull Set<PartialInfo> getRequiredPartialNames();
+
+    /**
+     * Returns the SHA256 hash of the source that was used to build this partial.
+     *
+     * @return the SHA256 hash of the source that was used to build this partial
+     */
+    @NotNull String getSHA256Hash();

Review comment:
       I was initially thinking that two partials should be equal irrespective of where they are coming from and hence wanted to force the various
   implementations to use the same hash algorithm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-schema-aggregator] sonarcloud[bot] removed a comment on pull request #2: SLING-10680 - Add support for versioning partials

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-graphql-schema-aggregator/pull/2#issuecomment-889181474


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&resolved=false&types=CODE_SMELL)
   
   [![86.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '86.7%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list) [86.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-schema-aggregator&pullRequest=2&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org