[GitHub] [datasketches-java] AlexanderSaydakov commented on pull request #428: Theta compression

["AlexanderSaydakov (via GitHub)" <gi...@apache.org>]

AlexanderSaydakov commented on PR #428:
URL: https://github.com/apache/datasketches-java/pull/428#issuecomment-1426529332

   A couple of shortcuts for now:
   1. wrap() delegates to heapify() for serial version 4. The alternative would be to have a special subclass such as DirectCompressedCompactSketch and a special support for it in set operations since they don't just iterate over any input sketch, but have special treatment (at least in the Union).
   2. union(Memory) in case of serial version 4 calls heapify() and then delegates to union(Sketch). This can be implemented later as decompression during union to avoid full decompression in case of the early stop. This is a potential performance improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org