You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "firasbouzazi (via GitHub)" <gi...@apache.org> on 2026/10/05 10:09:41 UTC
[PR] [common] Fix auto-partition time validation for quarter and invalid dates [fluss]
firasbouzazi opened a new pull request, #4549:
URL: https://github.com/apache/fluss/pull/4549
…ates
Validation of auto-partition time values had two problems:
1. The default QUARTER format "yyyyQ" could never be parsed: the variable-width quarter field cannot follow the adjacent year field, so even the current quarter (e.g. "20244") was rejected. Manually creating a partition or dynamically creating one from the client always failed for QUARTER auto-partitioned tables, and isPastAutoPartition always returned false for them.
2. Parsing used the SMART resolver, which accepts non-existent dates such as "20240230", "20230229" or hour "24", so such partitions could be created on auto-partitioned tables.
Parse partition time values with a strict parser that reads a single-letter quarter as a fixed-width field and range-checks it.
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink], [rust], [python], [c++], [elixir]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
- **Generative AI disclosure:** Indicate whether generative AI tools were used in authoring this PR. If yes, specify the tool below.
- [ ] No generative AI tools used
- [ ] Yes (please specify the tool below)
**(The sections below can be removed for hotfixes or typos)**
-->
<!--
Generated-by: [Tool Name and Version] following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #4548
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [common] Fix auto-partition time validation for quarter and invalid dates [fluss]
Posted by "firasbouzazi (via GitHub)" <gi...@apache.org>.
firasbouzazi commented on PR #4549:
URL: https://github.com/apache/fluss/pull/4549#issuecomment-6003366898
Hi @wuchong @polyzos Can you please take a look on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org