You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jujoramos (GitHub)" <gi...@apache.org> on 2019/10/24 10:05:41 UTC

[GitHub] [geode] jujoramos opened pull request #4218: GEODE-7313: Refactor QuerySecurityBase

- Fixed warnings.
- Replaced usages of 'junit.Assert' by 'assertj'.
- Refactored the tests to use new rules instead of deprecated code.
- Added extra tests to verify method invocation authorization in OQL.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4218 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on pull request #4218: GEODE-7313: Refactor QuerySecurityBase

Posted by "jujoramos (GitHub)" <gi...@apache.org>.
It is, indeed, I just have it here to avoid IDE warnings, thanks!.

[ Full content available at: https://github.com/apache/geode/pull/4218 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org