You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mateen Mansoori <ma...@gmail.com> on 2022/04/21 11:53:17 UTC
Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73954/
-----------------------------------------------------------
Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-3725
https://issues.apache.org/jira/browse/RANGER-3725
Repository: ranger
Description
-------
Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Diffs
-----
agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 7495b794d
Diff: https://reviews.apache.org/r/73954/diff/1/
Testing
-------
Tested on local VM - Audit filters are populating as expected.
Thanks,
Mateen Mansoori
Re: Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Posted by Mateen Mansoori <ma...@gmail.com>.
> On April 29, 2022, 3:33 a.m., bhavik patel wrote:
> > Upgrade use-case is handled?
Added changes to handle upgrade.
Thanks for the review.
- Mateen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73954/#review224387
-----------------------------------------------------------
On April 29, 2022, 9:06 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73954/
> -----------------------------------------------------------
>
> (Updated April 29, 2022, 9:06 a.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3725
> https://issues.apache.org/jira/browse/RANGER-3725
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 7495b794d
> security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 345e26ddb
>
>
> Diff: https://reviews.apache.org/r/73954/diff/2/
>
>
> Testing
> -------
>
> Tested on local VM - Audit filters are populating as expected.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73954/#review224387
-----------------------------------------------------------
Upgrade use-case is handled?
- bhavik patel
On April 21, 2022, 11:53 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73954/
> -----------------------------------------------------------
>
> (Updated April 21, 2022, 11:53 a.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3725
> https://issues.apache.org/jira/browse/RANGER-3725
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 7495b794d
>
>
> Diff: https://reviews.apache.org/r/73954/diff/1/
>
>
> Testing
> -------
>
> Tested on local VM - Audit filters are populating as expected.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73954/#review224386
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Shah
On April 21, 2022, 11:53 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73954/
> -----------------------------------------------------------
>
> (Updated April 21, 2022, 11:53 a.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3725
> https://issues.apache.org/jira/browse/RANGER-3725
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 7495b794d
>
>
> Diff: https://reviews.apache.org/r/73954/diff/1/
>
>
> Testing
> -------
>
> Tested on local VM - Audit filters are populating as expected.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73954/
-----------------------------------------------------------
(Updated April 29, 2022, 9:42 a.m.)
Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-3725
https://issues.apache.org/jira/browse/RANGER-3725
Repository: ranger
Description
-------
Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Diffs (updated)
-----
agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 7495b794d
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 345e26ddb
Diff: https://reviews.apache.org/r/73954/diff/3/
Changes: https://reviews.apache.org/r/73954/diff/2-3/
Testing
-------
Tested on local VM - Audit filters are populating as expected.
- verified upgrade case.
Thanks,
Mateen Mansoori
Re: Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73954/#review224390
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java
Lines 144 (patched)
<https://reviews.apache.org/r/73954/#comment313221>
if updateDefaultAuditFilter execution fails then also patch will continue. is this intentional ?
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java
Lines 145 (patched)
<https://reviews.apache.org/r/73954/#comment313220>
should this be logger.error or logger.info ?
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java
Lines 486 (patched)
<https://reviews.apache.org/r/73954/#comment313222>
add null check on embeddedAtlasServiceDef before calling embeddedAtlasServiceDef.getConfigs();
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java
Lines 498 (patched)
<https://reviews.apache.org/r/73954/#comment313223>
i think we should move this line after 499
- Pradeep Agrawal
On April 29, 2022, 9:06 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73954/
> -----------------------------------------------------------
>
> (Updated April 29, 2022, 9:06 a.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3725
> https://issues.apache.org/jira/browse/RANGER-3725
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
>
>
> Diffs
> -----
>
> agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 7495b794d
> security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 345e26ddb
>
>
> Diff: https://reviews.apache.org/r/73954/diff/2/
>
>
> Testing
> -------
>
> Tested on local VM - Audit filters are populating as expected.
> - verified upgrade case.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73954/
-----------------------------------------------------------
(Updated April 29, 2022, 9:06 a.m.)
Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Changes
-------
Handle upgrade.
Bugs: RANGER-3725
https://issues.apache.org/jira/browse/RANGER-3725
Repository: ranger
Description
-------
Update atlas default audit filter to filter Atlas entity-read events by Nifi user.
Diffs (updated)
-----
agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 7495b794d
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 345e26ddb
Diff: https://reviews.apache.org/r/73954/diff/2/
Changes: https://reviews.apache.org/r/73954/diff/1-2/
Testing
-------
Tested on local VM - Audit filters are populating as expected.
Thanks,
Mateen Mansoori