[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1155: interpreters/wamr/Kconfig: Add an option to enable wasi libc

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #1155:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1155#discussion_r880332885


##########
interpreters/wamr/Kconfig:
##########
@@ -58,6 +58,18 @@ config INTERPRETERS_WAMR_LIBC_BUILTIN
 	bool "Enable built-in libc"
 	default n
 
+config INTERPRETERS_WAMR_LIBC_WASI
+	bool "Enable WASI libc"
+	default n
+	---help---
+	Note: As of writing this, this works only with main branch of
+	wasm-micro-runtime.
+	I.e. INTERPRETERS_WAMR_VERSION="main"
+
+	Note: As of writing this, most of the filesystem operations are
+	not implemented. (Mainly because of lack of openat family of
+	the API in NuttX.)

Review Comment:
   ```suggestion
   	---help---
   		Note: As of writing this, this works only with main branch of
   		wasm-micro-runtime.
   		I.e. INTERPRETERS_WAMR_VERSION="main"
   
   		Note: As of writing this, most of the filesystem operations are
   		not implemented. (Mainly because of lack of openat family of
   		the API in NuttX.)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org