You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/01/24 10:00:13 UTC

[Bug 4768] New: spamc/libspamc.c uses C++ comment characters

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4768

           Summary: spamc/libspamc.c uses C++ comment characters
           Product: Spamassassin
           Version: 3.1.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: P5
         Component: Building & Packaging
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: nikc@cpan.org


spamc/libspamc.c uses C++/C99 comment characters "//", instead of "/*" and "*/".
 This causes problems for:

1.  Any compiler that does not handle these.

2.  Any compiler that can handle them, but needs a special option to enable this
feature.

This is essentially a duplicate of #4577, which includes a patch.  I've raised
this as a separate report because #4577 mistakenly reports that it only affects
IBM xlc on AIX -- I've run in to the problem on Solaris using Sun's Forte
compiler, and the problem is going to affect any environment with a picky compiler.

Please (a) apply the patch in #4577, and (b) consider an automated test for
SpamAssassin that does a slightly better version of "find . -name \*.[ch] -print
| xargs grep '//'" and fails if it finds any.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4768] spamc/libspamc.c uses C++ comment characters

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4768


felicity@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |4577
   Target Milestone|Undefined                   |3.1.6






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4768] spamc/libspamc.c uses C++ comment characters

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4768


Bug 4768 depends on bug 4577, which changed state.

Bug 4577 Summary: libsspamc.c syntax error with IBM xlc
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4577

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4768] spamc/libspamc.c uses C++ comment characters

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4768


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE




------- Additional Comments From jm@jmason.org  2006-09-06 17:57 -------
marking as dup.  note also that this issue has been fixed in recent 3.1.x releases.

for trunk, I've checked in a test that looks for these, too, and adds additional
gcc paranoid -Wflags: r440811.

*** This bug has been marked as a duplicate of 4577 ***



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.