You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/05 07:51:24 UTC
[GitHub] [iceberg] liuml07 opened a new pull request, #4699: Flink: improve unit tests for sink
liuml07 opened a new pull request, #4699:
URL: https://github.com/apache/iceberg/pull/4699
Initially I found the `TestIcebergFilesCommitter.java` always use the parquet file format for delete files. I think why not test with the parameterized file format as the data file does. Then I found the Flink sink tests maintain and pass variable `tablePath` unnecessarily. It can be replaced with `table` when comparing results, and can be replaced with `table.location()` when the absolute path is required.
I think the fix is straightforward enough so I consolidate the changes in this PR:
- Make sure the committer test use parameterized file format
- Simply test variables by removing `tablePath`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] liuml07 commented on a diff in pull request #4699: Flink: improve unit tests for sink
Posted by GitBox <gi...@apache.org>.
liuml07 commented on code in PR #4699:
URL: https://github.com/apache/iceberg/pull/4699#discussion_r865640504
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##########
@@ -743,14 +740,13 @@ public void testCommitTwoCheckpointsInSingleTxn() throws Exception {
private DeleteFile writeEqDeleteFile(FileAppenderFactory<RowData> appenderFactory,
String filename, List<RowData> deletes) throws IOException {
- return SimpleDataUtil.writeEqDeleteFile(table, FileFormat.PARQUET, tablePath, filename, appenderFactory, deletes);
Review Comment:
This should not be always `PARQUET` but `format`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4699: Flink: improve unit tests for sink
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4699:
URL: https://github.com/apache/iceberg/pull/4699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org