You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Krishna Mewara (Jira)" <ji...@apache.org> on 2026/08/02 06:48:00 UTC
[jira] [Updated] (FINERACT-2732) Migrate savings and deposit integration tests to the Feign client
[ https://issues.apache.org/jira/browse/FINERACT-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Krishna Mewara updated FINERACT-2732:
-------------------------------------
Description:
h3. Scope
20 test classes, around 209 tests, split across three PRs so each stays reviewable:
* Tier 1 - fill out the savings helpers, migrate the 14 small savings classes (48 tests)
* Tier 2 - ClientSavingsIntegrationTest (45 tests, the deepest one)
* Tier 3 - FixedDepositTest and Receposit helpers (85 tests)
New or extended helpers: savings bl, interest posting, transaction retrieval and search, savings charges, a savings validators module, and fresh helpers for fixed and recurring deposits and their pr
h3. Not included
* GroupSavingsIntegrationTest - needs FeignGroupHelper from FINERACT-2718, so it follows later
* AccountTransferTest - also drives batch
* Bulk import savings tests - file upload, tracked separately
h3. Done when
* No RestAssured left in the migrat
* Anything the generated model cannot express uses FeignRawHttpHelper and is written up in the raw-HTTP audit, with no assertion
* Single missing fields are fixed in the Swagger DTO and used through the typed setter
* Error cases check the exact HTTP ng was thrown
* Every migrated class actually ran and passed against a live server, with any test that was already failing beforehand called
* Full build is green
h3. For reviewers
No production code changes expected adding it is additive only - the wire format does not change, though the OpenAPI compatibility check may still flag it.
was:
h3. Scope
20 test classes, around 209 tests, split across three PRs so each stays reviewable:
* Tier 1 - fill out the savings helpers, migrate the 14 small savings classes (48 tests)
* Tier 2 - ClientSavingsIntegrationTest (45 tests, the deepest one)
* Tier 3 - FixedDepositTest and Receposit helpers (85 tests)
New or extended helpers: savings bl, interest posting, transaction retrieval and search, savings charges, a savings validators module, and fresh helpers for fixed and recurring deposits and their pr
h3. Not included
* GroupSavingsIntegrationTest - needs FeignGroupHelper from FINERACT-2718, so it follows later
* AccountTransferTest - also drives batch
* Bulk import savings tests - file upload, tracked separately
h3. Done when
* No RestAssured left in the migrat
* Anything the generated model cannot express uses FeignRawHttpHelper and is written up in the raw-HTTP audit, with no assertion
* Single missing fields are fixed in the Swagger DTO and used through the typed setter
* Error cases check the exact HTTP ng was thrown
* Every migrated class actually ran and passed against a live server, with any test that was already failing beforehand called
* Full build is green
h3. For reviewers
No production code changes expectedd adding it is additive only -
the wire format does not change, though the OpenAPI compatibility check may still flag it.
> Migrate savings and deposit integration tests to the Feign client
> -----------------------------------------------------------------
>
> Key: FINERACT-2732
> URL: https://issues.apache.org/jira/browse/FINERACT-2732
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Test
> Affects Versions: 1.15.0
> Reporter: Krishna Mewara
> Assignee: Krishna Mewara
> Priority: Trivial
> Labels: beginner-friendly, feign-migration, swagger, test
>
> h3. Scope
> 20 test classes, around 209 tests, split across three PRs so each stays reviewable:
> * Tier 1 - fill out the savings helpers, migrate the 14 small savings classes (48 tests)
> * Tier 2 - ClientSavingsIntegrationTest (45 tests, the deepest one)
> * Tier 3 - FixedDepositTest and Receposit helpers (85 tests)
> New or extended helpers: savings bl, interest posting, transaction retrieval and search, savings charges, a savings validators module, and fresh helpers for fixed and recurring deposits and their pr
> h3. Not included
> * GroupSavingsIntegrationTest - needs FeignGroupHelper from FINERACT-2718, so it follows later
> * AccountTransferTest - also drives batch
> * Bulk import savings tests - file upload, tracked separately
> h3. Done when
> * No RestAssured left in the migrat
> * Anything the generated model cannot express uses FeignRawHttpHelper and is written up in the raw-HTTP audit, with no assertion
> * Single missing fields are fixed in the Swagger DTO and used through the typed setter
> * Error cases check the exact HTTP ng was thrown
> * Every migrated class actually ran and passed against a live server, with any test that was already failing beforehand called
> * Full build is green
> h3. For reviewers
> No production code changes expected adding it is additive only - the wire format does not change, though the OpenAPI compatibility check may still flag it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)