You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/22 13:26:13 UTC
[GitHub] [jackrabbit-oak] nfsantos opened a new pull request, #718: OAK-9930 - Thread leak in elastic index statistics module
nfsantos opened a new pull request, #718:
URL: https://github.com/apache/jackrabbit-oak/pull/718
Reuse a Thread pool to execute the requests to refresh the cache in the Elastic Index statistics instead of creating a new thread pool for every refresh operation (these thread pools were not being terminated, so they were leaking, one per each refresh of the cache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #718: OAK-9930 - Thread leak in elastic index statistics module
Posted by GitBox <gi...@apache.org>.
fabriziofortino commented on code in PR #718:
URL: https://github.com/apache/jackrabbit-oak/pull/718#discussion_r978364437
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexStatistics.java:
##########
@@ -63,6 +65,15 @@ public class ElasticIndexStatistics implements IndexStatistics {
private static final LoadingCache<StatsRequestDescriptor, StatsResponse> STATS_CACHE =
setupCache(MAX_SIZE, EXPIRE_SECONDS, REFRESH_SECONDS, new StatsCacheLoader(), null);
+ private static final ExecutorService refreshExecutor = new ThreadPoolExecutor(
Review Comment:
this should be uppercase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] fabriziofortino merged pull request #718: OAK-9930 - Thread leak in elastic index statistics module
Posted by GitBox <gi...@apache.org>.
fabriziofortino merged PR #718:
URL: https://github.com/apache/jackrabbit-oak/pull/718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org