You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by hs...@apache.org on 2014/07/10 22:27:02 UTC
svn commit: r1609565 - in /incubator/flink: how-to-contribute.md
site/how-to-contribute.html
Author: hsaputra
Date: Thu Jul 10 20:27:01 2014
New Revision: 1609565
URL: http://svn.apache.org/r1609565
Log:
FLINK-1022 Fix doc link in how-to-contribute page to point to right coding_guidelines
Modified:
incubator/flink/how-to-contribute.md
incubator/flink/site/how-to-contribute.html
Modified: incubator/flink/how-to-contribute.md
URL: http://svn.apache.org/viewvc/incubator/flink/how-to-contribute.md?rev=1609565&r1=1609564&r2=1609565&view=diff
==============================================================================
--- incubator/flink/how-to-contribute.md (original)
+++ incubator/flink/how-to-contribute.md Thu Jul 10 20:27:01 2014
@@ -62,7 +62,7 @@ Go the website of your repository fork (
Before sending a patch or pull request, please verify that it complies with the guidelines of the project. While we try to keep the set of guidelines small and easy, it is important to follow those rules in order to guarantee good code quality, to allow efficient reviews, and to allow committers to easily merge your changes.
-Please have a look at the [coding guidelines](coding_guidelines.html) for a guide to the format of code and pull requests.
+Please have a look at the [coding guidelines]({{ site.baseurl }}/docs/{{ site.FLINK_CURRENT_DOCUMENTATION }}/coding_guidelines.html) for a guide to the format of code and pull requests.
Most important of all, verify that your changes are correct and do not break existing functionality. Run the existing tests by calling `mvn verify` in the root directory of the repository, and make sure that the tests succeed. We encourage every contributor to use a *continuous integration* service that will automatically test the code in your repository whenever you push a change. Flink is pre-configured for [Travis CI](http://docs.travis-ci.com/), which can be easily enabled for your private repository fork (it uses GitHub for authentication, so you so not need an additional account). Simply add the *Travis CI* hook to your repository (*settings --> webhooks & services --> add service*) and enable tests for the "incubator-flink" repository on [Travis](https://travis-ci.org/profile).
Modified: incubator/flink/site/how-to-contribute.html
URL: http://svn.apache.org/viewvc/incubator/flink/site/how-to-contribute.html?rev=1609565&r1=1609564&r2=1609565&view=diff
==============================================================================
--- incubator/flink/site/how-to-contribute.html (original)
+++ incubator/flink/site/how-to-contribute.html Thu Jul 10 20:27:01 2014
@@ -168,7 +168,7 @@ git rebase master
<p>Before sending a patch or pull request, please verify that it complies with the guidelines of the project. While we try to keep the set of guidelines small and easy, it is important to follow those rules in order to guarantee good code quality, to allow efficient reviews, and to allow committers to easily merge your changes.</p>
-<p>Please have a look at the <a href="coding_guidelines.html">coding guidelines</a> for a guide to the format of code and pull requests.</p>
+<p>Please have a look at the <a href="/docs/0.6-SNAPSHOT/coding_guidelines.html">coding guidelines</a> for a guide to the format of code and pull requests.</p>
<p>Most important of all, verify that your changes are correct and do not break existing functionality. Run the existing tests by calling <code>mvn verify</code> in the root directory of the repository, and make sure that the tests succeed. We encourage every contributor to use a <em>continuous integration</em> service that will automatically test the code in your repository whenever you push a change. Flink is pre-configured for <a href="http://docs.travis-ci.com/">Travis CI</a>, which can be easily enabled for your private repository fork (it uses GitHub for authentication, so you so not need an additional account). Simply add the <em>Travis CI</em> hook to your repository (<em>settings --> webhooks & services --> add service</em>) and enable tests for the "incubator-flink" repository on <a href="https://travis-ci.org/profile">Travis</a>.</p>