[GitHub] [openmeetings] solomax commented on a change in pull request #111: OPENMEETINGS-2434 Add some logging to better find out what env variable has been picked up.

[GitBox <gi...@apache.org>]

solomax commented on a change in pull request #111:
URL: https://github.com/apache/openmeetings/pull/111#discussion_r487733886



##########
File path: openmeetings-util/src/main/java/org/apache/openmeetings/util/OmFileHelper.java
##########
@@ -104,6 +104,7 @@ public static void setOmHome(File home) {
 		if (Strings.isEmpty(dataDir)) {
 			DATA_HOME = new File(OM_HOME, DATA_DIR);
 		} else {
+			log.info("Overwrite custom DATA_DIR: {}", dataDir);

Review comment:
       I would move this `log.info` out of `if/else` let it be logged :)))
   What is wrong with `ENV` variable?
   
   currently you can set the `DATA_DIR` in your `auto start script` and it will work forever
   In case of `applicationContext.xml` it has to be patched after each upgrade ....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org