You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by gvramana <gi...@git.apache.org> on 2017/04/10 12:03:52 UTC

[GitHub] incubator-carbondata pull request #656: [CARBONDATA-773] Fixed multiple Dict...

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/656#discussion_r106596051
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -524,8 +524,9 @@ case class LoadTable(
                 @throws[Exception]
                 def call: DictionaryServer = {
                   Thread.currentThread().setName("Dictionary server")
    -              val server: DictionaryServer = new DictionaryServer
    -              server.startServer(dictionaryServerPort.toInt)
    +              val server: DictionaryServer = DictionaryServer
    --- End diff --
    
    Dataloading shouldnot continue if dictionary server is failure.
    port initialization should happen and then port should be passed to LoadRDD


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---