You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/27 02:55:08 UTC

[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1023: Ftr/self discovery: Use invoker with same ip as client first.

LaurenceLiZhixin opened a new pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request. 
   -->
   
   **What this PR does**:
   Add feature :
   After client gets invoker lists from registry, if there is provider with the same ip as client, client would use the same ip first, which is not using wide network and faster.
   If it not exists the same ip provider, it would handle as normal way.
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   I add a router named selfDiscovery, which contains the router logic above.
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r565105004



##########
File path: cluster/router/selfDiscovery/self_disc_route.go
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self_disc
+
+import (
+	"github.com/RoaringBitmap/roaring"
+)
+
+import (
+	"github.com/apache/dubbo-go/cluster/router"
+	"github.com/apache/dubbo-go/cluster/router/utils"
+	"github.com/apache/dubbo-go/common"
+	"github.com/apache/dubbo-go/common/logger"
+	"github.com/apache/dubbo-go/protocol"
+)
+
+const (
+	selfDesc = "self-desc"

Review comment:
       Can you use `common.SelfDiscoveryRouterName` ?

##########
File path: cluster/router/selfDiscovery/factory.go
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self_disc

Review comment:
       dont use `_` in package name. I think can change to self




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#issuecomment-767983472


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=h1) Report
   > Merging [#1023](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=desc) (152d4dd) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d2a40aa49d22ca2ddea097c05b629fe39bf28a21?el=desc) (d2a40aa) will **decrease** coverage by `0.10%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1023/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop    #1023      +/-   ##
   ===========================================
   - Coverage    59.49%   59.38%   -0.11%     
   ===========================================
     Files          261      263       +2     
     Lines        12950    12988      +38     
   ===========================================
   + Hits          7704     7713       +9     
   - Misses        4273     4301      +28     
   - Partials       973      974       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/router/self/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZi9mYWN0b3J5Lmdv) | `66.66% <66.66%> (ø)` | |
   | [cluster/router/self/self\_priority\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZi9zZWxmX3ByaW9yaXR5X3JvdXRlLmdv) | `76.00% <76.00%> (ø)` | |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `51.11% <0.00%> (-8.89%)` | :arrow_down: |
   | [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-3.68%)` | :arrow_down: |
   | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `48.14% <0.00%> (-1.86%)` | :arrow_down: |
   | [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `43.02% <0.00%> (-1.29%)` | :arrow_down: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.92% <0.00%> (ø)` | |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=footer). Last update [d2a40aa...152d4dd](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r566291936



##########
File path: cluster/router/selfDiscovery/factory.go
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self_disc

Review comment:
        I don't think consistency leads to misunderstanding。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r567229138



##########
File path: cluster/router/self/factory.go
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self

Review comment:
       pls change the pkg name




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r565154360



##########
File path: cluster/router/selfDiscovery/factory.go
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self_disc

Review comment:
       Fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r565154064



##########
File path: cluster/router/selfDiscovery/self_disc_route.go
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self_disc
+
+import (
+	"github.com/RoaringBitmap/roaring"
+)
+
+import (
+	"github.com/apache/dubbo-go/cluster/router"
+	"github.com/apache/dubbo-go/cluster/router/utils"
+	"github.com/apache/dubbo-go/common"
+	"github.com/apache/dubbo-go/common/logger"
+	"github.com/apache/dubbo-go/protocol"
+)
+
+const (
+	selfDesc = "self-desc"

Review comment:
       `common.SelfDiscoveryRouterName` is to find out registered router. 
   `selfDesc` is to find the bitmap of target router in cache.
   In order to be consistent with the code design of other routers, I think your suggesting way can be confusing. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r566775882



##########
File path: cluster/router/selfDiscovery/factory.go
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self_disc

Review comment:
       > I think consistency for directory name and package name will not lead to misunderstanding.
   > 
   > And directory name should not be ‘aB’
   
   fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r566776041



##########
File path: go.sum
##########
@@ -176,6 +176,8 @@ github.com/dubbogo/go-zookeeper v1.0.2/go.mod h1:fn6n2CAEer3novYgk9ULLwAjuV8/g4D
 github.com/dubbogo/gost v1.9.0/go.mod h1:pPTjVyoJan3aPxBPNUX0ADkXjPibLo+/Ib0/fADXSG8=
 github.com/dubbogo/gost v1.10.1 h1:39kF9Cd5JOiMpmwG6dX1/aLWNFqFv9gHp8HrhzMmjLY=
 github.com/dubbogo/gost v1.10.1/go.mod h1:+mQGS51XQEUWZP2JeGZTxJwipjRKtJO7Tr+FOg+72rI=
+github.com/dubbogo/gost v1.11.0 h1:9KtyWQz1gMlAfwzen5iyhMdoe08SPBBUVhco4rdgJ9I=
+github.com/dubbogo/gost v1.11.0/go.mod h1:w8Yw29eDWtRVo3tx9nPpHkNZnOi4SRx1fZf7eVlAAU4=

Review comment:
       fixed
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cvictory commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r567562767



##########
File path: cluster/router/self/self_priority_route.go
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self
+
+import (
+	"github.com/RoaringBitmap/roaring"
+)
+
+import (
+	"github.com/apache/dubbo-go/cluster/router"
+	"github.com/apache/dubbo-go/cluster/router/utils"
+	"github.com/apache/dubbo-go/common"
+	"github.com/apache/dubbo-go/common/logger"
+	"github.com/apache/dubbo-go/protocol"
+)
+
+const (
+	selfPriority = "self-priority"
+	name         = "self-priority-router"
+)
+
+// SelfPriorityRouter provides a ip-same-first routing logic
+// if there is not provider with same ip as consumer, it would not filter any invoker
+// if exists same ip invoker, it would retains this invoker only
+type SelfPriorityRouter struct {
+	url     *common.URL
+	localIP string
+}
+
+// NewSelfPriorityRouter construct an SelfPriorityRouter via url
+func NewSelfPriorityRouter(url *common.URL) (router.PriorityRouter, error) {
+	r := &SelfPriorityRouter{
+		url:     url,
+		localIP: url.Ip,
+	}
+	return r, nil
+}
+
+// Route gets a list of match-logic invoker
+func (r *SelfPriorityRouter) Route(invokers *roaring.Bitmap, cache router.Cache, url *common.URL, invocation protocol.Invocation) *roaring.Bitmap {
+	addrPool := cache.FindAddrPool(r)
+	// Add selfPriority invoker to the list
+	selectedInvokers := utils.JoinIfNotEqual(addrPool[selfPriority], invokers)
+	// If all invokers are considered not match, downgrade to all invoker
+	if selectedInvokers.IsEmpty() {
+		logger.Warnf(" Now all invokers are not match, so downgraded to all! Service: [%s]", url.ServiceKey())

Review comment:
       maybe it should be logger.Debugf




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#issuecomment-770714715


   pls change the target branch to 1.5


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cvictory commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r567562841



##########
File path: cluster/router/self/self_priority_route.go
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self
+
+import (
+	"github.com/RoaringBitmap/roaring"
+)
+
+import (
+	"github.com/apache/dubbo-go/cluster/router"
+	"github.com/apache/dubbo-go/cluster/router/utils"
+	"github.com/apache/dubbo-go/common"
+	"github.com/apache/dubbo-go/common/logger"
+	"github.com/apache/dubbo-go/protocol"
+)
+
+const (
+	selfPriority = "self-priority"
+	name         = "self-priority-router"
+)
+
+// SelfPriorityRouter provides a ip-same-first routing logic
+// if there is not provider with same ip as consumer, it would not filter any invoker
+// if exists same ip invoker, it would retains this invoker only
+type SelfPriorityRouter struct {
+	url     *common.URL
+	localIP string
+}
+
+// NewSelfPriorityRouter construct an SelfPriorityRouter via url
+func NewSelfPriorityRouter(url *common.URL) (router.PriorityRouter, error) {
+	r := &SelfPriorityRouter{
+		url:     url,
+		localIP: url.Ip,
+	}
+	return r, nil
+}
+
+// Route gets a list of match-logic invoker
+func (r *SelfPriorityRouter) Route(invokers *roaring.Bitmap, cache router.Cache, url *common.URL, invocation protocol.Invocation) *roaring.Bitmap {
+	addrPool := cache.FindAddrPool(r)
+	// Add selfPriority invoker to the list
+	selectedInvokers := utils.JoinIfNotEqual(addrPool[selfPriority], invokers)
+	// If all invokers are considered not match, downgrade to all invoker
+	if selectedInvokers.IsEmpty() {
+		logger.Warnf(" Now all invokers are not match, so downgraded to all! Service: [%s]", url.ServiceKey())
+		return invokers
+	}
+	return selectedInvokers
+}
+
+// Pool separates same ip invoker from others.
+func (r *SelfPriorityRouter) Pool(invokers []protocol.Invoker) (router.AddrPool, router.AddrMetadata) {
+	rb := make(router.AddrPool, 8)
+	rb[selfPriority] = roaring.NewBitmap()
+	selfIpFound := false
+	for i, invoker := range invokers {
+		if invoker.GetUrl().Ip == r.localIP {
+			rb[selfPriority].Add(uint32(i))
+			selfIpFound = true
+		}
+	}
+	if selfIpFound {
+		// found self desc
+		logger.Debug("found self ip ")
+		return rb, nil
+	}
+	for i, _ := range invokers {
+		rb[selfPriority].Add(uint32(i))
+	}
+	return rb, nil
+}
+
+// ShouldPool will always return true to make sure self call logic constantly.
+func (r *SelfPriorityRouter) ShouldPool() bool {
+	return true
+}
+
+func (r *SelfPriorityRouter) Name() string {
+	return name
+}
+
+// Priority
+func (r *SelfPriorityRouter) Priority() int64 {
+	return 0

Review comment:
       the priority should be latest




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#issuecomment-767983472


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=h1) Report
   > Merging [#1023](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=desc) (512b6c6) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c8fb3e934a6c3d15a0792a1396d0c122272f772c?el=desc) (c8fb3e9) will **decrease** coverage by `0.00%`.
   > The diff coverage is `58.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1023/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop    #1023      +/-   ##
   ===========================================
   - Coverage    59.54%   59.53%   -0.01%     
   ===========================================
     Files          261      263       +2     
     Lines        12957    12978      +21     
   ===========================================
   + Hits          7715     7727      +12     
   - Misses        4266     4277      +11     
   + Partials       976      974       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `63.04% <ø> (ø)` | |
   | [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `32.95% <0.00%> (ø)` | |
   | [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `11.56% <ø> (-0.21%)` | :arrow_down: |
   | [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `50.42% <42.85%> (+0.02%)` | :arrow_up: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `50.36% <57.14%> (-0.77%)` | :arrow_down: |
   | [cluster/router/selfDiscovery/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9mYWN0b3J5Lmdv) | `66.66% <66.66%> (ø)` | |
   | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `64.15% <75.00%> (-0.77%)` | :arrow_down: |
   | [cluster/router/selfDiscovery/self\_disc\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9zZWxmX2Rpc2Nfcm91dGUuZ28=) | `76.00% <76.00%> (ø)` | |
   | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `50.00% <100.00%> (ø)` | |
   | ... and [14 more](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=footer). Last update [4a721a2...1353c33](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#issuecomment-767983472


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=h1) Report
   > Merging [#1023](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=desc) (347efa8) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d2a40aa49d22ca2ddea097c05b629fe39bf28a21?el=desc) (d2a40aa) will **increase** coverage by `0.25%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1023/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop    #1023      +/-   ##
   ===========================================
   + Coverage    59.49%   59.74%   +0.25%     
   ===========================================
     Files          261      263       +2     
     Lines        12950    12978      +28     
   ===========================================
   + Hits          7704     7754      +50     
   + Misses        4273     4248      -25     
   - Partials       973      976       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/router/selfDiscovery/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9mYWN0b3J5Lmdv) | `66.66% <66.66%> (ø)` | |
   | [cluster/router/selfDiscovery/self\_disc\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9zZWxmX2Rpc2Nfcm91dGUuZ28=) | `76.00% <76.00%> (ø)` | |
   | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `73.49% <0.00%> (-2.41%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `51.42% <0.00%> (+1.63%)` | :arrow_up: |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.12% <0.00%> (+2.19%)` | :arrow_up: |
   | [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.00% <0.00%> (+2.94%)` | :arrow_up: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `45.31% <0.00%> (+17.96%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=footer). Last update [d2a40aa...a5b3ed4](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #1023: Ftr/self discovery: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#issuecomment-767983472


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=h1) Report
   > Merging [#1023](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=desc) (8414d85) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/17c4a9e4e65ad9822a7262f5e39949f818e9bed1?el=desc) (17c4a9e) will **increase** coverage by `0.09%`.
   > The diff coverage is `75.86%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1023/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop    #1023      +/-   ##
   ===========================================
   + Coverage    59.45%   59.55%   +0.09%     
   ===========================================
     Files          261      263       +2     
     Lines        12950    12979      +29     
   ===========================================
   + Hits          7700     7730      +30     
   + Misses        4276     4273       -3     
   - Partials       974      976       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/router/selfDiscovery/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9mYWN0b3J5Lmdv) | `66.66% <66.66%> (ø)` | |
   | [cluster/router/selfDiscovery/self\_disc\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9zZWxmX2Rpc2Nfcm91dGUuZ28=) | `76.92% <76.92%> (ø)` | |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `48.78% <0.00%> (+4.87%)` | :arrow_up: |
   | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (+8.33%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=footer). Last update [17c4a9e...512b6c6](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r566291936



##########
File path: cluster/router/selfDiscovery/factory.go
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package self_disc

Review comment:
       I think consistency  for directory name and package name will not lead to misunderstanding.
   
   And directory name should not be ‘aB’




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#discussion_r565221110



##########
File path: go.sum
##########
@@ -176,6 +176,8 @@ github.com/dubbogo/go-zookeeper v1.0.2/go.mod h1:fn6n2CAEer3novYgk9ULLwAjuV8/g4D
 github.com/dubbogo/gost v1.9.0/go.mod h1:pPTjVyoJan3aPxBPNUX0ADkXjPibLo+/Ib0/fADXSG8=
 github.com/dubbogo/gost v1.10.1 h1:39kF9Cd5JOiMpmwG6dX1/aLWNFqFv9gHp8HrhzMmjLY=
 github.com/dubbogo/gost v1.10.1/go.mod h1:+mQGS51XQEUWZP2JeGZTxJwipjRKtJO7Tr+FOg+72rI=
+github.com/dubbogo/gost v1.11.0 h1:9KtyWQz1gMlAfwzen5iyhMdoe08SPBBUVhco4rdgJ9I=
+github.com/dubbogo/gost v1.11.0/go.mod h1:w8Yw29eDWtRVo3tx9nPpHkNZnOi4SRx1fZf7eVlAAU4=

Review comment:
       using `go mod tidy` to delete the useless gost version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1023: Ftr: Use invoker with same ip as client first.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1023:
URL: https://github.com/apache/dubbo-go/pull/1023#issuecomment-767983472


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=h1) Report
   > Merging [#1023](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=desc) (512b6c6) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/17c4a9e4e65ad9822a7262f5e39949f818e9bed1?el=desc) (17c4a9e) will **increase** coverage by `0.07%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1023/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop    #1023      +/-   ##
   ===========================================
   + Coverage    59.45%   59.53%   +0.07%     
   ===========================================
     Files          261      263       +2     
     Lines        12950    12978      +28     
   ===========================================
   + Hits          7700     7727      +27     
   - Misses        4276     4277       +1     
     Partials       974      974              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cluster/router/selfDiscovery/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9mYWN0b3J5Lmdv) | `66.66% <66.66%> (ø)` | |
   | [cluster/router/selfDiscovery/self\_disc\_route.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvc2VsZkRpc2NvdmVyeS9zZWxmX2Rpc2Nfcm91dGUuZ28=) | `76.00% <76.00%> (ø)` | |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `71.09% <0.00%> (+3.12%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1023/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `48.78% <0.00%> (+4.87%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=footer). Last update [17c4a9e...512b6c6](https://codecov.io/gh/apache/dubbo-go/pull/1023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org