You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/11/16 22:09:36 UTC
[bookkeeper] branch master updated: Fix cpu-affinity module build
on jdk10+
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 0c623d5 Fix cpu-affinity module build on jdk10+
0c623d5 is described below
commit 0c623d54ed15102667d2d1ac389998a1ffdcf11c
Author: Enrico Olivelli <eo...@gmail.com>
AuthorDate: Fri Nov 16 23:09:31 2018 +0100
Fix cpu-affinity module build on jdk10+
Port tricks from circe-checksum to cpu-affinity module in order to make the build pass on JDK11
Reviewers: Sijie Guo <si...@apache.org>, Matteo Merli <mm...@apache.org>
This closes #1816 from eolivelli/fix/jdk11-cpu-affinity-build
---
cpu-affinity/pom.xml | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/cpu-affinity/pom.xml b/cpu-affinity/pom.xml
index f58a079..1439259 100644
--- a/cpu-affinity/pom.xml
+++ b/cpu-affinity/pom.xml
@@ -73,6 +73,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
+ <version>${maven-assembly-plugin.version}</version>
<configuration>
<descriptors>
<descriptor>src/main/assembly/assembly.xml</descriptor>
@@ -105,6 +106,53 @@
<profiles>
<profile>
+ <!-- from JDK10 javah command is not available
+ see http://openjdk.java.net/jeps/313
+ -->
+ <id>jdk-without-javah</id>
+ <activation>
+ <jdk>[10,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>com.github.maven-nar</groupId>
+ <artifactId>nar-maven-plugin</artifactId>
+ <version>${nar-maven-plugin.version}</version>
+ <extensions>true</extensions>
+ <executions>
+ <execution>
+ <!-- javah is not present in JDK10 onwards,
+ you have to to use javac -h -->
+ <id>default-nar-javah</id>
+ <phase>none</phase>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>${maven-compiler-plugin.version}</version>
+ <configuration>
+ <source>1.8</source>
+ <target>1.8</target>
+ <compilerArgs>
+ <!-- Object.finalize() is deprecated at java 9 -->
+ <!-- <compilerArg>-Werror</compilerArg> -->
+ <compilerArg>-Xlint:deprecation</compilerArg>
+ <compilerArg>-Xlint:unchecked</compilerArg>
+ <!-- https://issues.apache.org/jira/browse/MCOMPILER-205 -->
+ <compilerArg>-Xpkginfo:always</compilerArg>
+ <!-- add -h flag to javac -->
+ <compilerArg>-h</compilerArg>
+ <compilerArg>${project.build.directory}/nar/javah-include</compilerArg>
+ </compilerArgs>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
<id>mac</id>
<activation>
<os>