You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/22 17:50:57 UTC

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #15621: [WIP] MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)

pengzhao-intel commented on issue #15621: [WIP] MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)
URL: https://github.com/apache/incubator-mxnet/pull/15621#issuecomment-513886419
 
 
   > Could you elaborate where "MXNET_USE_MKLDNN_RNN" comes from? Out of scope of the PR, but why did we introduce that switch instead of just going with it?
   
   @marcoabreu some background of this env variable. We had pulled in the MKL-DNN RNN integration in 1.5 by the application team for RNN/LSTM. So we set an env to make a rollback for the user in case there are un-expected functionality and performance degree. Now, we are refactoring the code and add the whole support for RNN API. This variable will be removed in the near future.
   
   What's your opinion?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services