You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/07/11 03:51:58 UTC
[GitHub] [incubator-linkis] jackxu2011 opened a new pull request, #2457: [issue-2456] fix(linkis-bml): fix a test bug
jackxu2011 opened a new pull request, #2457:
URL: https://github.com/apache/incubator-linkis/pull/2457
### What is the purpose of the change
the linkis-bml VersionServiceImplTest fail
Related issues: #2456 .
### Brief change log
(for example:)
- the general path have a current dateStr, replace the fixed str with dateformat
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- Anything that affects deployment: no
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2457: [issue-2456] fix(linkis-bml): fix a test bug
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2457:
URL: https://github.com/apache/incubator-linkis/pull/2457#issuecomment-1179944454
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2457?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2457](https://codecov.io/gh/apache/incubator-linkis/pull/2457?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0da5400) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/5aa4f6d6085e503b540651009374d94481d2d1ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5aa4f6d) will **decrease** coverage by `1.49%`.
> The diff coverage is `14.28%`.
```diff
@@ Coverage Diff @@
## dev-1.2.0 #2457 +/- ##
===============================================
- Coverage 18.09% 16.59% -1.50%
- Complexity 1094 1103 +9
===============================================
Files 597 636 +39
Lines 17788 19520 +1732
Branches 2651 2769 +118
===============================================
+ Hits 3219 3240 +21
- Misses 14135 15843 +1708
- Partials 434 437 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2457?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../main/java/org/apache/linkis/common/io/FsPath.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi9pby9Gc1BhdGguamF2YQ==) | `0.00% <ø> (ø)` | |
| [...n/java/org/apache/linkis/common/utils/DESUtil.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi91dGlscy9ERVNVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/linkis/bml/service/impl/VersionServiceImpl.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWJtbC9saW5raXMtYm1sLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2JtbC9zZXJ2aWNlL2ltcGwvVmVyc2lvblNlcnZpY2VJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/linkis/jobhistory/cache/utils/MD5Util.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWpvYmhpc3Rvcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9qb2JoaXN0b3J5L2NhY2hlL3V0aWxzL01ENVV0aWwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/linkis/bml/common/HdfsResourceHelper.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWJtbC9saW5raXMtYm1sLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2JtbC9jb21tb24vSGRmc1Jlc291cmNlSGVscGVyLmphdmE=) | `12.85% <50.00%> (ø)` | |
| [.../apache/linkis/bml/common/LocalResourceHelper.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWJtbC9saW5raXMtYm1sLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2JtbC9jb21tb24vTG9jYWxSZXNvdXJjZUhlbHBlci5qYXZh) | `5.71% <50.00%> (ø)` | |
| [...va/org/apache/linkis/bml/Entity/DownloadModel.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWJtbC9saW5raXMtYm1sLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2JtbC9FbnRpdHkvRG93bmxvYWRNb2RlbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ava/org/apache/linkis/bml/Entity/ResourceTask.java](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWJtbC9saW5raXMtYm1sLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2JtbC9FbnRpdHkvUmVzb3VyY2VUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...inkis/bml/common/BmlResourceExpiredException.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWJtbC9saW5raXMtYm1sLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ibWwvY29tbW9uL0JtbFJlc291cmNlRXhwaXJlZEV4Y2VwdGlvbi5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/incubator-linkis/pull/2457/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2457?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2457?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [36ffb16...0da5400](https://codecov.io/gh/apache/incubator-linkis/pull/2457?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #2457: [issue-2456] fix(linkis-bml): fix a test bug
Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2457:
URL: https://github.com/apache/incubator-linkis/pull/2457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org