[jira] [Commented] (FLINK-7459) Introduce RedirectHandler for the WebRuntimeMonitor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128984#comment-16128984 ] 

ASF GitHub Bot commented on FLINK-7459:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4551

    [FLINK-7459] Generalize Flink's redirection logic

    ## What is the purpose of the change
    
    Introduce RedirectHandler which can be extended to add redirection functionality to all
    SimpleInboundChannelHandlers. This allows to share the same functionality across the
    StaticFileServerHandler and the RuntimeMonitorHandlerBase which could now be removed.
    In the future, the AbstractRestHandler will also extend the RedirectHandler.
    
    This PR is based on #4549.
    
    ## Brief change log
    
    - Introduce `RedirectHandler` which encapsulates the redirection logic
    - Let `StaticFileServerHandler` and `RuntimeMonitorHandler` extend the `RedirectHandler`
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
    - Added test `RedirectHandlerTest` which tests the redirection logic
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink generalizeWebRedirect

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4551
    
----
commit 2c0c36244f75de000f884618330bc2f885c91d76
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-10T08:56:12Z

    [FLINK-7409] [web] Make WebRuntimeMonitor reactive
    
    This commit changes the behaviour of the WebRuntimeMonitor to not longer block serving
    threads by waiting on the result of futures. Instead the RequestHandler now returns a
    CompletableFuture<FullHttpResponse> which is written out to the Netty channel upon
    completion. This will improve the performance of our WebRuntimeMonitor.

commit 01c8666677a24d65b8d75c49696bc8ab9e254d99
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-15T10:00:58Z

    [FLINK-7458] Generalize GatewayRetriever for WebRuntimeMonitor
    
    Introduce a generalized GatewayRetriever replacing the JobManagerRetriever. The
    GatewayRetriever fulfills the same purpose as the JobManagerRetriever with the
    ability to retrieve the gateway for an arbitrary endpoint type.

commit b44bc2eb0085e7e7f3b4d13e1942ceb28a0e00c8
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-15T11:55:47Z

    [FLINK-7459] Generalize Flink's redirection logic
    
    Introduce RedirectHandler which can be extended to add redirection functionality to all
    SimpleInboundChannelHandlers. This allows to share the same functionality across the
    StaticFileServerHandler and the RuntimeMonitorHandlerBase which could now be removed.
    In the future, the AbstractRestHandler will also extend the RedirectHandler.

----


> Introduce RedirectHandler for the WebRuntimeMonitor
> ---------------------------------------------------
>
>                 Key: FLINK-7459
>                 URL: https://issues.apache.org/jira/browse/FLINK-7459
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination, Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> Currently, the {{StaticFileServerHandler}} and the {{RuntimeMonitorHandlerBase}} both have functionality to redirect the requests to the current leader. In the future, there will be an {{AbstractRestHandler}} for Flip-6 which also needs this functionality. 
> I therefore propose to create a general purpose {{RedirectHandler}} which can be extended to automatically add support for redirection.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)