[GitHub] [incubator-doris] morningman commented on a change in pull request #6391: Support long text type STRING with a maximum length of 2GB

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #6391:
URL: https://github.com/apache/incubator-doris/pull/6391#discussion_r689987389



##########
File path: be/src/exec/olap_rewrite_node.cpp
##########
@@ -135,18 +135,17 @@ bool OlapRewriteNode::copy_one_row(TupleRow* src_row, Tuple* tuple, MemPool* poo
         const TColumnType& column_type = _column_types[i];
         switch (column_type.type) {
         case TPrimitiveType::CHAR:
-        case TPrimitiveType::VARCHAR: {
+        case TPrimitiveType::VARCHAR:
+        case TPrimitiveType::STRING: {
             // Fixed length string
-            StringValue* str_val = (StringValue*)src_value;
-            if (str_val->len > column_type.len) {
+            StringValue* str_val = (StringValue*)src_value; if (str_val->len > column_type.len) {

Review comment:
       wrong format?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org